Skip to content

[Snyk] Security upgrade @onekeyfe/cross-inpage-provider-core from 0.0.17 to 1.1.58#722

Open
revan-zhang wants to merge 1 commit intoonekeyfrom
snyk-fix-d935b12de87e89aada17406da73c06f0
Open

[Snyk] Security upgrade @onekeyfe/cross-inpage-provider-core from 0.0.17 to 1.1.58#722
revan-zhang wants to merge 1 commit intoonekeyfrom
snyk-fix-d935b12de87e89aada17406da73c06f0

Conversation

@revan-zhang
Copy link
Copy Markdown
Contributor

@revan-zhang revan-zhang commented Apr 1, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/hd-web-sdk/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  645  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Prototype Pollution


Note

Medium Risk
Upgrades a core postMessage bridge dependency from 0.0.17 to ^1.1.58, which could introduce breaking behavior changes in the iframe/bridge integration despite being a security-motivated bump.

Overview
Updates packages/hd-web-sdk/package.json to upgrade @onekeyfe/cross-inpage-provider-core from ^0.0.17 to ^1.1.58 (Snyk security bump).

No code changes are included, but the new dependency version may affect runtime behavior where JsBridgeIframe/postMessage bridging is used.

Written by Cursor Bugbot for commit 16e1d71. This will update automatically on new commits. Configure here.


Open with Devin

@revan-zhang
Copy link
Copy Markdown
Contributor Author

revan-zhang commented Apr 1, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 1 additional finding in Devin Review.

Open in Devin Review

},
"dependencies": {
"@onekeyfe/cross-inpage-provider-core": "^0.0.17",
"@onekeyfe/cross-inpage-provider-core": "^1.1.58",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 yarn.lock not updated for major version bump of cross-inpage-provider-core

The package.json bumps @onekeyfe/cross-inpage-provider-core from ^0.0.17 to ^1.1.58 (a major version change), but the yarn.lock file was not updated — it still only contains an entry for ^0.0.17 resolving to 0.0.17 (yarn.lock:4779-4789). Running yarn install with --frozen-lockfile (as CI typically does) will fail because the lockfile doesn't satisfy the new version constraint. Without --frozen-lockfile, the lockfile would be regenerated, but the PR as-is is incomplete and will break reproducible builds.

Prompt for agents
Run `yarn install` (or the equivalent lockfile update command for this monorepo) to regenerate the yarn.lock file so it includes a resolution for `@onekeyfe/cross-inpage-provider-core@^1.1.58`. The updated yarn.lock must be committed alongside the package.json change. Also verify that the APIs used in packages/hd-web-sdk/src/utils/bridgeUtils.ts (JsBridgeIframe, setPostMessageListenerFlag, IJsBridgeIframeConfig) are still exported and compatible in the 1.x version of @onekeyfe/cross-inpage-provider-core, since this is a major version bump from 0.x.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

},
"dependencies": {
"@onekeyfe/cross-inpage-provider-core": "^0.0.17",
"@onekeyfe/cross-inpage-provider-core": "^1.1.58",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lockfile not updated, security fix not applied

High Severity

The package.json now requires @onekeyfe/cross-inpage-provider-core at ^1.1.58, but the yarn.lock still resolves @onekeyfe/cross-inpage-provider-core@^0.0.17 to version 0.0.17, which transitively depends on the vulnerable lodash ^4.17.21. Until yarn.lock is regenerated, the actual installed version remains 0.0.17 and the Prototype Pollution vulnerability (SNYK-JS-LODASH-15053838) this PR aims to fix is not actually remediated. Merging this as-is creates a false sense of security.

Fix in Cursor Fix in Web

},
"dependencies": {
"@onekeyfe/cross-inpage-provider-core": "^0.0.17",
"@onekeyfe/cross-inpage-provider-core": "^1.1.58",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version bump risks breaking API compatibility

High Severity

Upgrading @onekeyfe/cross-inpage-provider-core from 0.0.x to 1.1.x is a major version bump. The codebase imports JsBridgeIframe, setPostMessageListenerFlag, and IJsBridgeIframeConfig from this package in bridgeUtils.ts. A major version change very likely includes breaking API changes (renamed exports, changed constructor signatures, removed functions). Once the lockfile is updated to actually resolve v1.1.58, the build may fail or behave incorrectly.

Fix in Cursor Fix in Web

@socket-security
Copy link
Copy Markdown

@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: npm cipher-base is missing type checks, leading to hash rewind and passing on crafted data

CVE: GHSA-cpq7-6gpm-g9rc cipher-base is missing type checks, leading to hash rewind and passing on crafted data (CRITICAL)

Affected versions: < 1.0.5

Patched version: 1.0.5

From: ?npm/ripple-keypairs@1.3.0npm/cipher-base@1.0.4

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/cipher-base@1.0.4. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Critical
Critical CVE: Elliptic's private key extraction in ECDSA upon signing a malformed input (e.g. a string)

CVE: GHSA-vjh7-7g9h-fjfh Elliptic's private key extraction in ECDSA upon signing a malformed input (e.g. a string) (CRITICAL)

Affected versions: < 6.6.1

Patched version: 6.6.1

From: ?npm/ripple-keypairs@1.3.0npm/elliptic@6.5.4

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/elliptic@6.5.4. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Critical
Critical CVE: npm sha.js is missing type checks leading to hash rewind and passing on crafted data

CVE: GHSA-95m3-7q98-8xr5 sha.js is missing type checks leading to hash rewind and passing on crafted data (CRITICAL)

Affected versions: < 2.4.12

Patched version: 2.4.12

From: ?npm/ripple-keypairs@1.3.0npm/sha.js@2.4.11

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/sha.js@2.4.11. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: ?npm/cheerio@1.0.0-rc.12npm/entities@4.5.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@4.5.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants