Skip to content

[868gfp7y1] RoR upgrade (v5.0.0)#38

Open
ale1HQagui wants to merge 16 commits intomasterfrom
ror_upgrade
Open

[868gfp7y1] RoR upgrade (v5.0.0)#38
ale1HQagui wants to merge 16 commits intomasterfrom
ror_upgrade

Conversation

@ale1HQagui
Copy link
Copy Markdown

Description

Please describe your pull request and any relevant information.

Risk Level

  • Low
  • Med
  • High

Rollback Plan

Please describe and add steps for rollback if needed.

Screenshots

Screenshots or videos of the feature/fix if needed.

Checklist

  • I linked the change to an approved ticket
  • I have added/updated appropriate tests and evidence
  • I considered security/privacy impact
  • I updated docs/runbook if needed
  • I added a changelog/version entry for this PR

@grvp88
Copy link
Copy Markdown
Contributor

grvp88 commented Apr 9, 2026

Code Review — Rails 7.2 / Ruby 3.4 Compatibility Analysis

⚠️ Sin CI configurado para esta rama

No hay checks reportados en ror_upgrade. Misma situación que has_normalized_attributes.


✅ Compatible con Rails 7.2 y Ruby 3.4

Gemspec Rails range correcto: ">= 6.0", "<= 7.2.3" — consistente con el ecosistema.

required_ruby_version >= 3.4 — correcto.

testhq ~> 5.0.0.pre.beta.5 y has_normalized_attributes ~> 5.0.0.pre.beta.3 — alineados con el upgrade.

Spec string literal fix — Ruby 3.4

# Antes (triple-quote ambiguo, cambia de significado en Ruby 3.x)
subject.email_attr = """test\blah""@example.com"

# Después (explícito)
subject.email_attr = "" "test\blah" "@example.com"

Adjacent string literal concatenation es la forma correcta en Ruby 3.4.

🟡 Observación: has_validated_attributes/rspec.rb — indentación rota

# Después del cambio
each do |str|
it { should allow_value(str).for(attr) }
end

El it quedó sin indentación dentro del bloque each. Es solo cosmético pero dificulta la lectura de los shared examples.

@grvp88
Copy link
Copy Markdown
Contributor

grvp88 commented Apr 9, 2026

TODOs antes de mergear

  • Activar CI — no hay checks reportados para esta rama. Verificar que CircleCI o Tekton está corriendo specs en ror_upgrade.
  • Indentación en rspec.rb shared examples — el it dentro del bloque each quedó sin indentación. Cosmético, pero dificulta leer los shared examples. Fix de 2 líneas.
  • Changelog sin newline al final — el CHANGELOG.md termina sin newline. Agregar \n al final del archivo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants