Skip to content

Enable http communication between block validator and validation server #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmikolajczyk41 merged 2 commits into from
Mar 17, 2026
Merged

Enable http communication between block validator and validation server #4499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07a1805
Allow http scheme in block validator
pmikolajczyk41 Mar 12, 2026
5bc2b59
Changelog
pmikolajczyk41 Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog/pmikolajczyk-nit-4652.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
### Changed
- Enable http communication between block validator and validation server
5 changes: 3 additions & 2 deletions staker/block_validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"fmt"
"net/url"
"regexp"
"slices"
"sync"
"sync/atomic"
"testing"
Expand Down Expand Up @@ -203,8 +204,8 @@ func (c *BlockValidatorConfig) Validate() error {
if err != nil {
return fmt.Errorf("failed parsing validation server's url:%s err: %w", serverUrl, err)
}
if u.Scheme != "ws" && u.Scheme != "wss" {
return fmt.Errorf("validation server's url scheme is unsupported, it should either be ws or wss, url:%s", serverUrl)
if !slices.Contains([]string{"ws", "wss", "http", "https"}, u.Scheme) {
return fmt.Errorf("validation server's url scheme is unsupported, it should be ws, wss, http, or https, url:%s", serverUrl)
}
}
}
Expand Down
Loading