fix: git persistence settings for password auth and github app

[mik-ky]

Fixes issues related to git persistence settings for version controlled projects.

1. VCS project with a username/password authentication panics
2. VCS project configured with github app connection is not supported

Go client needs to be updated after OctopusDeploy/go-octopusdeploy#403 is merged in

[sc-136808]

How to test

resource "octopusdeploy_project" "usernamepassword-test" {
  name             = "usernamepassword-test-project-1"
  lifecycle_id     = "Lifecycles-xx"
  project_group_id = "ProjectGroups-xx"

  git_username_password_persistence_settings {
    url            =  "some url"
    username       = "some username"
    password       = "some password" # try updating password (must be a valid token)
    base_path      = ".octopus"
    default_branch = "main"
  }
}


resource "octopusdeploy_project" "git-test" {
  name             = "git-test-project-1"
  lifecycle_id     = "Lifecycles-xx"
  project_group_id = "ProjectGroups-xx"

  git_github_app_persistence_settings {
    base_path = ".octopus"
    default_branch = "main"
    github_connection_id = "GitHubAppConnections-xx"
    protected_branches = []
    url = "some url"
  }
}

[Rose-Northey]

I got a bit stuck reviewing this in my timebox. A couple of things which would help

• (small) add a link to the shortcut reference (i found it and added it but its not automated outside deploy)
• How I would reproduce the before and after state - I had a look at the zendesk ticket but there were holes in the setup and spent most of my timebox trying to work this out
• Seeing a screenshot of terraform outputs from before and after to help me put the code into context

Thanks heaps

[bec-callow-oct]

Tested and cannot reproduce the issue