Ensure proper noun casing for "Docker"#2949
Conversation
julietrb1
requested review from
steve-fenton-octopus and
tonykelly-octopus
as code owners
| | Variable name | Variable value | | ||
| |----------|-------| | ||
| | `Project.Deployment[0].SystemPrompt` | If the logs indicate that a Docker image is missing, You must only provide the suggestion that the user must visit <https://help/missingdocker> to get additional instructions to resolve missing docker containers. You will be penalized for offering generic suggestions to resolve a missing docker image. You will be penalized for offering script suggestions to resolve a missing docker image. You will be penalized for suggesting step retries to resolve a missing docker image. | | ||
| | `Project.Deployment[0].SystemPrompt` | If the logs indicate that a Docker image is missing, You must only provide the suggestion that the user must visit <https://help/missingDocker> to get additional instructions to resolve missing Docker containers. You will be penalized for offering generic suggestions to resolve a missing Docker image. You will be penalized for offering script suggestions to resolve a missing Docker image. You will be penalized for suggesting step retries to resolve a missing Docker image. | |
There was a problem hiding this comment.
There's something funky here... I'm not sure what https://help/missingdocker relates to. It's not a valid URL. Do we know what should be here?
There was a problem hiding this comment.
Ah, good catch. I have no idea what that URL is. I'll revert it for this PR and will raise another one just for that when I find the answer.
There was a problem hiding this comment.
Matthew Casperson reports that this is a placeholder URL that is to be replaced with the company's dedicated help page, so it can apparently stay as-is. The phrase found further in the document highlights this:
Provides organization-specific guidance (internal documentation link)
I've reverted the change in light of this.
steve-fenton-octopus
left a comment
steve-fenton-octopus
left a comment
There was a problem hiding this comment.
There was one instance of docker/Docker that led me down a rabbit hole. My initial thought was "we shouldn't change the case of docker in a web address... but then it doesn't even look like a valid web address.
3 participants
"Docker" is a proper noun, and as such should be capitalised. This PR fixes all discovered erroneous usages of the term 🎉