Skip to content

If the test process wont die, don't fail the build just ignore it and proceed #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukeButters merged 5 commits into from
May 1, 2026
+4 −0
Merged

If the test process wont die, don't fail the build just ignore it and proceed #1215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d83ed68
If the test process wont die, don't fail the build just ignore it and…
LukeButters Apr 30, 2026
d7c834a
.
LukeButters Apr 30, 2026
715103b
.
LukeButters Apr 30, 2026
bbb0c41
.
LukeButters Apr 30, 2026
3fafaa1
.
LukeButters Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build/Build.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@
using Serilog;
using static Nuke.Common.Tools.DotNet.DotNetTasks;

// macOS build agents are persistent (non-ephemeral), so compiler server processes may need to be cleaned up between builds.
Copy link
Copy Markdown
Contributor Author

@LukeButters LukeButters Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other agents are ephemeral so we wont need this on them.

Also we don't do this on octopus.

#if MACOS
[ShutdownDotNetAfterServerBuild]
#endif
partial class Build : NukeBuild
{
/// Support plugins are available for:
Expand Down
1 change: 1 addition & 0 deletions build/_build.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<NukeScriptDirectory>..</NukeScriptDirectory>
<NukeTelemetryVersion>1</NukeTelemetryVersion>
<Nullable>enable</Nullable>
<DefineConstants Condition="$([MSBuild]::IsOSPlatform('OSX'))">$(DefineConstants);MACOS</DefineConstants>
</PropertyGroup>

<ItemGroup>
Expand Down