Add OpenCRE as a map analysis resource#825
Open
Bornunique911 wants to merge 2 commits intoOWASP:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
This branch addresses:
#469Add OpenCRE itself to mapanalysisProblem
OpenCRE already acts as the central requirement graph, but it is not currently exposed as a selectable resource in
map_analysis.That means users can compare external standards to each other, but they cannot directly compare a standard against OpenCRE itself. This limits a useful workflow described in the issue, such as understanding how a standard maps into OpenCRE coverage.
Solution
This branch adds OpenCRE itself as a supported map-analysis resource.
1. Add OpenCRE to the standards list
The
/rest/v1/standardsresponse now includesOpenCREso it can be selected like other map-analysis resources.2. Add direct map-analysis support for OpenCRE
When one side of
/rest/v1/map_analysisisOpenCRE, the backend now builds the result directly from CRE-to-standard links instead of sending the request through the normal queued standard-to-standard flow.This works by:
3. Keep the implementation narrow
This branch only adds the minimal backend behavior needed for
OpenCREto behave as a map-analysis resource. It does not change the general gap-analysis queue model for other standard-to-standard requests.Testing
Executed focused validation with:
./venv/bin/python -m pytest application/tests/web_main_test.py -k 'standards_from_db or supports_opencre_as_standard' -q