Skip to content

fix: correct tag handling in dbNodeFromCode#822

Open
akashrajeev wants to merge 2 commits intoOWASP:mainfrom
akashrajeev:fix-dbnode-tags
Open

fix: correct tag handling in dbNodeFromCode#822
akashrajeev wants to merge 2 commits intoOWASP:mainfrom
akashrajeev:fix-dbnode-tags

Conversation

@akashrajeev
Copy link

Fixes #821

Summary

This PR fixes incorrect tag handling in dbNodeFromCode in application/database/db.py.

Tags were being joined from an empty variable instead of code.tags, causing them to always be stored as empty even when values were present.

Changes

  • Updated tag join logic to use code.tags

Impact

  • Fixes loss of tag metadata for Code nodes
  • Improves correctness of stored data and related features

Testing

  • Verified locally that tags are now stored correctly
  • Confirmed no regressions in existing functionality

@akashrajeev
Copy link
Author

Hi @Pa04rth ,

I’ve opened this PR to fix the tag handling issue in dbNodeFromCode. (Issue #821 )

Would really appreciate your feedback when you get a chance — happy to make any changes if needed.

@PRAteek-singHWY
Copy link
Contributor

Hi @akashrajeev , I think this PR isn’t signed yet. Could you please check it once and then reach out to a maintainers @Pa04rth , @northdpole , and @robvanderveer on Slack .

Thanks for the contribution .

@Pa04rth
Copy link
Collaborator

Pa04rth commented Mar 26, 2026

@akashrajeev Sync and sign your PR

@akashrajeev
Copy link
Author

Hi @Pa04rth ,
I’ve synced the branch and updated the PR with a signed commit.
Please let me know if anything else is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect tag handling in dbNodeFromCode leads to empty tags

3 participants