fix: correct tag handling in dbNodeFromCode#822
Open
akashrajeev wants to merge 2 commits intoOWASP:mainfrom
Open
fix: correct tag handling in dbNodeFromCode#822akashrajeev wants to merge 2 commits intoOWASP:mainfrom
akashrajeev wants to merge 2 commits intoOWASP:mainfrom
Conversation
Author
Contributor
|
Hi @akashrajeev , I think this PR isn’t signed yet. Could you please check it once and then reach out to a maintainers @Pa04rth , @northdpole , and @robvanderveer on Slack . Thanks for the contribution . |
Collaborator
|
@akashrajeev Sync and sign your PR |
Author
|
Hi @Pa04rth , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #821
Summary
This PR fixes incorrect tag handling in
dbNodeFromCodeinapplication/database/db.py.Tags were being joined from an empty variable instead of
code.tags, causing them to always be stored as empty even when values were present.Changes
code.tagsImpact
Testing