Add user/group id config to compose to remove need for sudo#38
Open
ChrysmOre wants to merge 4 commits into
Open
Add user/group id config to compose to remove need for sudo#38ChrysmOre wants to merge 4 commits into
ChrysmOre wants to merge 4 commits into
Conversation
redhug1
reviewed
Sep 30, 2021
Contributor
redhug1
left a comment
redhug1
left a comment
There was a problem hiding this comment.
See direct comments in Slack.
This is not working at all well, if at all on MacBook's
ChrysmOre
force-pushed
the
feature/remove-need-for-sudo
branch
4 times, most recently
from
fe7c57b to
b1677e1
Compare
ChrysmOre
force-pushed
the
feature/remove-need-for-sudo
branch
2 times, most recently
from
b44d36f to
b7704ab
Compare
ChrysmOre
force-pushed
the
feature/remove-need-for-sudo
branch
2 times, most recently
from
08db951 to
3524dc1
Compare
cookel2
requested changes
Oct 22, 2021
|
|
||
| To use the `start-import` helpers scripts or analysis tools you will need | ||
| to set an environment variable called `FLORENCE_PASSWORD` to your local | ||
| florence login password for `florence@magicroundabout.gov.uk`. Alternatively |
Contributor
There was a problem hiding this comment.
The ons part is missed out:
Suggested change
| florence login password for `florence@magicroundabout.gov.uk`. Alternatively | |
| florence login password for `florence@magicroundabout.ons.gov.uk`. Alternatively |
ChrysmOre
force-pushed
the
feature/remove-need-for-sudo
branch
from
3524dc1 to
d1c6a36
Compare
Contributor
|
In the test-docker-compose section the version of go should probably be changed to 1.17 in go.mod. |
cookel2
requested changes
Oct 26, 2021
Contributor
There was a problem hiding this comment.
If I try to run the start-import.sh then it gives me this error:
Making request to POST import-api/jobs:{"recipe":"38542eb6-d3a6-4cc4-ba3f-32b25f23223a"}
error posting job to importAPI: error performing request: Post "http://localhost:21800/jobs": EOF
exit status 1
| * Adjust the constant `maxRuns` in `test-compose.go` for the number of times you want the process to run. Each loop of the process may take about 3 minutes. You may also need to adjust `maxContainersInJob` to match the number of containers that are run for the cantabular import process (which may change). | ||
|
|
||
| * First run `./run-cantabular-without-sudo.sh` in its directory and then when all containers running, run `./start-import.sh` in its directory to test that at least one import process completes OK | ||
| * First run `make start` and then when all containers running, run `./start-import.sh` in its directory to test that at least one import process completes OK |
Contributor
There was a problem hiding this comment.
It took me a few minutes to locate the start-import.sh so I think it would be useful to say that it's in the helpers directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added
make-privilegedmake target and changed regularmake startto not use sudo. Removed extraneous scripts and updated references and READMEs to reference make targets and existing scripts instead.Have also added The Train to the compose journey.
How to test
Test changes make sense.
Test existing helpers and analysis journeys still work (
test-docker-compose,start-analysis)Verify
the-traincontainer starts up successfully (will see calls to/v1/healthin the logs, albeit they will return 404 as the train doesn't have a health endpoint!)