Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions endpoint_route_handler/models/endpoint_route_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ class EndpointRouteHandler(models.AbstractModel):
index=True,
compute="_compute_route",
inverse="_inverse_route",
precompute=True,
readonly=False,
store=True,
copy=False,
Expand Down
28 changes: 28 additions & 0 deletions endpoint_route_handler/tests/test_endpoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# @author: Simone Orsi <simone.orsi@camptocamp.com>
# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
from contextlib import contextmanager
from unittest.mock import patch

from odoo import api, modules
from odoo.tests import common
Expand Down Expand Up @@ -50,6 +51,33 @@ def test_as_tool_base_data(self):
new_route.route += "/new"
self.assertNotEqual(new_route.endpoint_hash, first_hash)

def test_route_field_precomputed(self):
"""``route`` is required + computed; precompute=True makes the compute
run before INSERT so downstream modules that derive ``route`` from
other fields don't get a "Missing required value" error at create
time.

Self-contained verification: patch ``_compute_route`` to derive a
deterministic value (simulating what a downstream override would do),
then ``create()`` a record without passing ``route``. If precompute
fires before INSERT, the derived value lands on the record. Without
precompute, INSERT would fail before ``_compute_route`` runs.
"""
Model = type(self.env["endpoint.route.handler.tool"])

def _fake_compute_route(self):
for rec in self:
rec.route = "/precompute/probe"

with patch.object(Model, "_compute_route", _fake_compute_route):
rec = self.env["endpoint.route.handler.tool"].create(
{
"name": "Precompute test",
"request_method": "GET",
}
)
self.assertEqual(rec.route, "/precompute/probe")

@mute_logger("odoo.addons.base.models.ir_http")
def test_as_tool_register_single_controller(self):
new_route = make_new_route(self.env)
Expand Down
Loading