Skip to content

[18.0][FIX] date_range: Tree editor mark 'date end' as end#1267

Open
qgroulard wants to merge 1 commit intoOCA:18.0from
acsone:18.0-fix-date_range_tree_editor_end_date-qgr
Open

[18.0][FIX] date_range: Tree editor mark 'date end' as end#1267
qgroulard wants to merge 1 commit intoOCA:18.0from
acsone:18.0-fix-date_range_tree_editor_end_date-qgr

Conversation

@qgroulard
Copy link
Copy Markdown

Without this fix we skip two days (first and last) when using date range domains, because the first day was set to start at 23:59:59 and the last day to finish at 00:00:00.

Before:

image

After:

image

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

Copy link
Copy Markdown
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @qgroulard

Copy link
Copy Markdown
Member

@samirGuesmi samirGuesmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants