[18.0][IMP] base_custom_filter: add configurable insertion point for filter groups, etc.#1220
Open
yostashiro wants to merge 4 commits intoOCA:18.0from
Open
[18.0][IMP] base_custom_filter: add configurable insertion point for filter groups, etc.#1220yostashiro wants to merge 4 commits intoOCA:18.0from
yostashiro wants to merge 4 commits intoOCA:18.0from
Conversation
Contributor
|
Hi @ForgeFlow, @AshishHirapara, |
Member
Author
|
The main improvement: we now have better control over where the custom filters should show. 
|
kanda999
approved these changes
Jan 19, 2026
kanda999
left a comment
kanda999
left a comment
There was a problem hiding this comment.
Functional review: it works as expected in runboat
Contributor
|
I added a new commit to allow creation of date filters. |
|
Functional review. LGTM |
SanamiK
approved these changes
Apr 8, 2026
Replace context-based filtering in get_filters() with post-filtering approach that excludes non-favorite filter types from results, preventing custom filters from appearing in the Favorites section.
yostashiro
force-pushed
the
18.0-imp-base_custom_filter
branch
from
2cb6d46 to
fa5ef41
Compare
… groups - Add insert_xpath, insert_position, and separator_position fields to ir.filters.group for controlling filter placement in search views - Support XPath-based targeting with customizable separator placement - Add XPath syntax validation constraint - Refactor filter/groupby insertion with fallback node resolution so custom filters work even when //search/filter node doesn't exist
Allow creation of date filters with automatic period options (Today, This Week, This Month, This Quarter, This Year). Users can now select a date/datetime field when creating Standard Filters as an alternative to domain-based filtering.
yostashiro
force-pushed
the
18.0-imp-base_custom_filter
branch
from
fa5ef41 to
372ce79
Compare
Contributor
|
This PR has the |
yostashiro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@qrtl QT6218