Skip to content

[19.0][MIG] onchange_helper: Migration to 19.0#3519

Merged
OCA-git-bot merged 61 commits intoOCA:19.0from
DeineTuer-GmbH:19.0-mig-onchange_helper
Mar 14, 2026
Merged

[19.0][MIG] onchange_helper: Migration to 19.0#3519
OCA-git-bot merged 61 commits intoOCA:19.0from
DeineTuer-GmbH:19.0-mig-onchange_helper

Conversation

@sergijPf
Copy link
Copy Markdown

simple migration + fixed tests

florian-dacosta and others added 30 commits February 10, 2026 15:45
other improvement:

set onchange_specs to all fields as _onchange_spec()
retrun onchange fields for default view
return field value if it's set in onchange_fields (usuful to get default value for a field)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-12.0/server-tools-12.0-onchange_helper
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-onchange_helper/
Currently translated at 100.0% (1 of 1 strings)

Translation: server-tools-12.0/server-tools-12.0-onchange_helper
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-onchange_helper/zh_CN/
Rad0van and others added 13 commits February 10, 2026 15:45
Without explicit web dependency all tests fail like this:

File "/home/odoo/src/odoo/odoo/models.py", line 6905, in onchange
    raise NotImplementedError("onchange() is implemented in module 'web'")
NotImplementedError: onchange() is implemented in module 'web'
…ed by

As the onchange method can be a little bulky, we don't call it if fields passed as
arguments are not in _onchange_methods
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-18.0/server-tools-18.0-onchange_helper
Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-onchange_helper/
@sergijPf sergijPf mentioned this pull request Feb 10, 2026
43 tasks
@sergijPf sergijPf force-pushed the 19.0-mig-onchange_helper branch from f7d0837 to 5753c45 Compare February 10, 2026 14:51
Copy link
Copy Markdown
Contributor

@petrus-v petrus-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this migration 👍

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Copy Markdown
Member

hbrunn commented Mar 14, 2026

/ocabot migration onchange_helper
/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-3519-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Mar 14, 2026
@OCA-git-bot OCA-git-bot merged commit e7c5198 into OCA:19.0 Mar 14, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 940728c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.