[19.0][MIG] sale_tier_validation: Migration to 19.0 by niboo-vli · Pull Request #3968 · OCA/sale-workflow

niboo-vli · 2025-10-24T16:09:04Z

No description provided.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_tier_validation/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_tier_validation/

Currently translated at 100.0% (13 of 13 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_tier_validation/zh_CN/

Currently translated at 100.0% (13 of 13 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_tier_validation/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_tier_validation/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_tier_validation/

…m.team

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_tier_validation/

Currently translated at 100.0% (19 of 19 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_tier_validation/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_tier_validation/

Currently translated at 100.0% (20 of 20 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_tier_validation/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/es/

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/it/

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/sv/

bosd · 2026-01-06T11:01:46Z

@niboo-vli Thanks for the migration. Can you please add a test-requirements.txt ?

git+https://github.com/em230418/tier-validation@19.0-mig-base_tier_validation#subdirectory=base_tier_validation

So it depends on: OCA/tier-validation#1

OpenCode · 2026-02-04T17:38:28Z

I think you can create a PR to migrate the module directly in https://github.com/OCA/tier-validation

is-ife · 2026-02-05T13:18:55Z

@@ -0,0 +1,83 @@
+# Copyright 2020 Sergio Teruel <sergio.teruel@tecnativa.com>
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).


AGPL-3.0 or LGPL-3.0?

bosd · 2026-02-10T19:45:21Z

I think you can create a PR to migrate the module directly in https://github.com/OCA/tier-validation

Looks like there already is one: OCA/tier-validation#9

alexey-pelykh

Thanks for porting this module.

The main blocker right now is the unreleased dependency: base_tier_validation has not been merged to 19.0 yet on OCA/server-ux (see server-ux#1234 -- tests pass but pre-commit still fails there). This explains both CI test failures (test with Odoo and test with OCB).

Once that dependency lands, there are a few things to address in this PR:

License mismatch in test file (already flagged by @is-ife): tests/test_tier_validation.py header says LGPL-3.0 but the manifest declares AGPL-3. Should be AGPL-3.0 to match.
pricelist_id in test setup: The test creates a sale order with "pricelist_id": cls.customer.property_product_pricelist.id. In Odoo 17+, pricelist handling on res.partner changed. Verify that property_product_pricelist still resolves correctly in 19.0 and that the pricelist_id field is still required on sale.order. If not, this line can be dropped.
Translation function: The self.env._() pattern in reports/sale_report.py is correct for 19.0 -- good catch on updating that from the 18.0 _() import.

Code-wise the module looks solid -- clean model inheritance, proper tier validation hookup via _state_from/_state_to, correct notification subtypes, and adequate test coverage. No issues with the XML views or data files.

Please rebase once base_tier_validation is available on 19.0 and fix the license header.

alexey-pelykh · 2026-03-01T16:55:57Z

@@ -0,0 +1,83 @@
+# Copyright 2020 Sergio Teruel <sergio.teruel@tecnativa.com>
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).


License should be AGPL-3.0 to match the module manifest ("license": "AGPL-3"). Currently says LGPL-3.0.

alexey-pelykh · 2026-03-01T16:55:57Z

+                ],
+                "pricelist_id": cls.customer.property_product_pricelist.id,
+            }
+        )


In Odoo 17+, property_product_pricelist on res.partner was refactored. Verify this still resolves correctly in 19.0. If pricelist_id is no longer required on sale.order, you can drop this line entirely -- other 19.0 modules (e.g. sale_exception) create the pricelist explicitly rather than relying on the partner property.

victoralmau · 2026-03-17T11:07:59Z

Please, cherry-pick #4197 to commit history before migration commit.

rousseldenis · 2026-03-27T09:47:59Z

@niboo-vli Could you attend comments ?

osi-mgosai and others added 30 commits October 24, 2025 17:47

[ADD] 12.0 Sale Tier Validation module added

1b83a9d

updated version 11 to 12

f930569

Added dependency as requested

6472ae3

Removed dependency and added to oca-dependencies.txt

1336f1d

[UPD] Update sale_tier_validation.pot

e1f353c

[IMP] sale_tier_validation: black, isort

a3e7fbf

[MIG] sale_tier_validation: Migration to v13.0

b6d0497

Translated using Weblate (Spanish)

500f2cc

Currently translated at 100.0% (13 of 13 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_tier_validation/es/

[14.0][MIG] sale_tier_validation

d7dce67

Added translation using Weblate (Swedish)

b26831e

[MIG] sale_tier_validation: Migration to 15.0

203737f

[IMP] sale_tier_validation: Make tests more resilient

ab878b4

[IMP] sale_tier_validation: Add subtypes to allow subscriptions by cr…

6fcbb13

…m.team

[IMP] sale_tier_validation: Make subtypes internal

566ac21

Added translation using Weblate (Spanish (Mexico))

acd85b9

[MIG] sale_tier_validation: Migration to 16.0

039509d

Added translation using Weblate (Turkish)

cdeae28

[15.0][FIX] Sales order states in tier validation

75d23ac

[IMP] sale_tier_validation: Add in ROADMAP sent validation problem

b1cf89c

Translated using Weblate (Spanish)

e247901

Currently translated at 100.0% (19 of 19 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_tier_validation/es/

Convert sale_tier_validation readme fragments to markdown

c9a151c

Translated using Weblate (Spanish)

92ea2f3

Currently translated at 100.0% (20 of 20 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_tier_validation/es/

Added translation using Weblate (Italian)

9fc61a1

celm1990 and others added 13 commits October 24, 2025 17:47

[IMP] sale_tier_validation: pre-commit auto fixes

9a3ab76

[MIG] sale_tier_validation: Migration to 17.0

ea38155

Translated using Weblate (Spanish)

e9d8843

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/es/

Translated using Weblate (Italian)

7e6b300

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/it/

Translated using Weblate (Swedish)

9c7d3b1

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/sv/

[IMP] sale_tier_validation: add the option for blocking sale order print

1aa9392

[IMP] sale_tier_validation: pre-commit auto fixes

80e33ed

[MIG] sale_tier_validation: Migration to version 18.0

9f75af5

[UPD] Update sale_tier_validation.pot

5808191

[BOT] post-merge updates

56033ef

Added translation using Weblate (Portuguese)

9c6ca58

[19.0][MIG] sale_tier_validation: Migration to 19.0

8f68ae7

is-ife reviewed Feb 5, 2026

View reviewed changes

alexey-pelykh suggested changes Mar 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] sale_tier_validation: Migration to 19.0#3968

[19.0][MIG] sale_tier_validation: Migration to 19.0#3968
niboo-vli wants to merge 43 commits intoOCA:19.0from
niboo-odoo:19.0-mig-sale_tier_validation

niboo-vli commented Oct 24, 2025

Uh oh!

bosd commented Jan 6, 2026

Uh oh!

OpenCode commented Feb 4, 2026

Uh oh!

is-ife Feb 5, 2026

Uh oh!

bosd commented Feb 10, 2026

Uh oh!

alexey-pelykh left a comment

Uh oh!

alexey-pelykh Mar 1, 2026

Uh oh!

alexey-pelykh Mar 1, 2026

Uh oh!

victoralmau commented Mar 17, 2026

Uh oh!

rousseldenis commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

		@@ -0,0 +1,83 @@
		# Copyright 2020 Sergio Teruel <sergio.teruel@tecnativa.com>
		# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).

Uh oh!

Conversation

niboo-vli commented Oct 24, 2025

Uh oh!

bosd commented Jan 6, 2026

Uh oh!

OpenCode commented Feb 4, 2026

Uh oh!

is-ife Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

bosd commented Feb 10, 2026

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

victoralmau commented Mar 17, 2026

Uh oh!

rousseldenis commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants