Skip to content

[18.0][FIX] report_csv: add None check for docids in _render_csv#1117

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
nuobit:18.0-fix-report_csv
Mar 20, 2026
Merged

[18.0][FIX] report_csv: add None check for docids in _render_csv#1117
OCA-git-bot merged 1 commit intoOCA:18.0from
nuobit:18.0-fix-report_csv

Conversation

@deeniiz
Copy link
Copy Markdown
Contributor

@deeniiz deeniiz commented Jan 9, 2026

It is being assumed that the parameter docids is always iterable, and len(docids) is called without validation, which therefore raises an error.

@deeniiz
Copy link
Copy Markdown
Contributor Author

deeniiz commented Jan 9, 2026

@eantones , can you please review it?

Copy link
Copy Markdown

@eantones eantones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sergijPf
Copy link
Copy Markdown

@deeniiz There is a similar fix for v16.0 (+related test) and it was already merged #962,
you can replace your commit with that one, probably, it'll go faster then.

@HviorForgeFlow
Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1117-by-HviorForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 33089fd into OCA:18.0 Mar 20, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at a1f9c9c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants