[19.0][MIG] sale_project_copy_tasks: Migration to 19.0#1646
Open
bizzappdev wants to merge 8 commits intoOCA:19.0from
Open
[19.0][MIG] sale_project_copy_tasks: Migration to 19.0#1646bizzappdev wants to merge 8 commits intoOCA:19.0from
bizzappdev wants to merge 8 commits intoOCA:19.0from
Conversation
Without this patch, upgrading the addon raises this error:
Field 'partner_id' used in context ({'default_partner_id': partner_id, 'default_sale_order_id': active_id}) must be present in view but is missing.
@moduon MT-3426
…d always This reverts OCA#1416 and adds instead a different, more accurate fix for the problem (which kept yielding different errors). The main source of problem is that the same view is adding a `project_id` field and editing another `project_id` fields' attributes. For this reason, installing the module didn't give any problems, but updating it was problematic. The new field appeared above in the view hierarchy than the old one. The xpath for the old one was less specific than necessary, and then found the new one instead. The new one is within a tree subview, so the model is different (`sale.order.line` instead of `sale.order`). Thus the fields exposed to that field are different, and failures happened a bit randomly. @moduon MT-3426
|
Runboat is not available for testing. Is something wrong? |
alexey-pelykh
approved these changes
Feb 28, 2026
Contributor
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for taking this on. The copy_tasks_in_project service tracking type is well implemented — product template, sale order, and sale order line extensions all look good. Clean migration. LGTM.
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.