[18.0] [MIG] pos_session_pay_invoice by Tisho99 · Pull Request #1472 · OCA/pos

Tisho99 · 2026-01-12T10:40:09Z

Standard migration

The pos order is now created in draft state because we can no longer create pos payments in posted pos orders. The 'invoiced' state is assigned after that
The refund of the setUpClass is now generated from a new invoice because in v18 the original and refund moves were being automatically conciliated

T-9200

javierizaca

Functional review completed. The module works as expected, allowing payments to be made from the backend of an active session. LGTM.

ValentinVinagre · 2026-01-20T15:28:48Z

            "partner_id": self.invoice_id.partner_id.id,
            "account_move": self.invoice_id.id,
-            "state": "invoiced",
+            "state": "draft",


Is it validated at some point?

It is validated (or set as 'invoiced') here: https://github.com/OCA/pos/pull/1472/files#diff-f228ebf7313229f41451c1c8f72b80d566b40b9075e7fefd8dfac7313711e159R92

I searched for highet level function in pos.order to assign the state, but found anything useful for this case

Have you tried the following function 'action_pos_order_invoice' which calls '_generate_pos_order_invoice' which generates an invoice and marks the 'pos order' as invoiced?

https://github.com/odoo/odoo/blob/bcc1397c7d694dbe61ecbd44d0320b9518df84cb/addons/point_of_sale/models/pos_order.py#L984C9-L984C33

https://github.com/odoo/odoo/blob/bcc1397c7d694dbe61ecbd44d0320b9518df84cb/addons/point_of_sale/models/pos_order.py#L1010

We don't have to generate a new invoice, the invoice is already generated. We are associating a new pos order with an already created invoice. So using that function does not make sense for me

ValentinVinagre

LGTM 👍🏻

pedrobaeza · 2026-03-19T09:46:08Z

/ocabot migration pos_session_pay_invoice

cristina-hidalgo-tecnativa

I've tested this locally, both at code level and functionally.

Regarding the CI/CD failures, they don't seem related to this module at all — for example, the IrModuleModule._load_pos_data_fields() error (tracked in odoo/odoo#241122) was already fixed in the OCB via commit OCA/OCB@692620ab6.

Also, the module's own tests pass cleanly on my end, so LGTM.

Currently translated at 100.0% (30 of 30 strings) Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/it/

…rders createds with this module

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/

Currently translated at 100.0% (8 of 8 strings) Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/it/

…S session To prevent mistakes, users must select only the journals available in the pos.payment.method of the POS session.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/

… customer transactions Before this commit, the wizard generated an account.bank.statement.line, but the problem was that when the POS had cash control enabled, all transactions generated by this wizard were displayed under Cash, because Odoo considered such statements as Cash In/Out operations, see https://github.com/odoo/odoo/blob/c1d3153ed564c0f47a201e5751740857a15d7db2/addons/point_of_sale/models/pos_session.py#L557-L567. Now, the transactions are shown under Cash or Bank depending on the payment method and journal type. For payments of vendor bills, a statement line will still be created, because the POS only works with receivable accounts and cannot reconcile with payable accounts. See https://github.com/odoo/odoo/blob/c1d3153ed564c0f47a201e5751740857a15d7db2/addons/point_of_sale/models/pos_order.py#L890-L898

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/

Currently translated at 100.0% (12 of 12 strings) Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/it/

Tisho99 · 2026-03-24T08:22:46Z

Rebased to see if the tests pass now

pedrobaeza · 2026-03-25T07:19:35Z

Waiting OCA/oca-ci#123 for the CI to greenify.

Tisho99 · 2026-03-25T14:25:57Z

Hello @pedrobaeza

This pull request is ready, in case you want to review it or merge it.

Thanks!

pedrobaeza · 2026-03-25T15:03:55Z

/ocabot merge nobump

OCA-git-bot · 2026-03-25T15:04:04Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1472-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2026-03-25T15:12:19Z

Congratulations, your PR was merged at e826150. Thanks a lot for contributing to OCA. ❤️

Tisho99 force-pushed the 18.0-mig-pos_session_pay_invoice branch 3 times, most recently from 642bbe1 to 6bfe20c Compare January 16, 2026 14:18

Tisho99 marked this pull request as ready for review January 16, 2026 14:20

Tisho99 force-pushed the 18.0-mig-pos_session_pay_invoice branch 2 times, most recently from dd612a9 to 868f215 Compare January 19, 2026 14:48

javierizaca approved these changes Jan 20, 2026

View reviewed changes

ValentinVinagre suggested changes Jan 20, 2026

View reviewed changes

Tisho99 force-pushed the 18.0-mig-pos_session_pay_invoice branch from 868f215 to 9d88a07 Compare January 21, 2026 16:18

ValentinVinagre approved these changes Jan 22, 2026

View reviewed changes

OCA-git-bot added the approved label Jan 22, 2026

Tisho99 force-pushed the 18.0-mig-pos_session_pay_invoice branch from 9d88a07 to 6dabf01 Compare February 10, 2026 08:20

pedrobaeza requested a review from cristina-hidalgo-tecnativa March 19, 2026 09:46

OCA-git-bot added this to the 18.0 milestone Mar 19, 2026

OCA-git-bot mentioned this pull request Mar 19, 2026

Migration to version 18.0 #1251

Open

33 tasks

cristina-hidalgo-tecnativa approved these changes Mar 24, 2026

View reviewed changes

etobella and others added 13 commits March 24, 2026 09:21

[ADD] PoS session pay invoice module

ef1cf86

Migration of pos_session_pay_invoice to 11.0

7af0504

Fix account-payment's github repo url

3a93624

[12.0][MIG] pos_session_pay_invoice

c3b2869

Added translation using Weblate (Spanish)

26ec3a4

Added translation using Weblate (French)

2c3c3ac

[IMP] pos_session_pay_invoice: black, isort, prettier

bff4f7f

[13.0][MIG] pos_session_pay_invoice

d7088e2

[MIG] pos_session_pay_invoice: Ending migration to 13.0

98406c6

[IMP] pos_session_pay_invoice: black, isort, prettier

3fd655e

[MIG] pos_session_pay_invoice: Migration to 14.0

b2054d6

[UPD] Update pos_session_pay_invoice.pot

7da0005

Added translation using Weblate (Italian)

eccec91

OCA-git-bot and others added 17 commits March 24, 2026 09:21

[BOT] post-merge updates

e163f00

Translated using Weblate (Italian)

b5be54c

Currently translated at 100.0% (30 of 30 strings) Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/it/

[FIX] pos_session_pay_invoice: search_paid_order_ids must exclude o…

2f7f6d3

…rders createds with this module

[UPD] Update pos_session_pay_invoice.pot

cc55358

[BOT] post-merge updates

8e62408

Update translation files

72ed302

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/

Translated using Weblate (Italian)

51ddaa1

Currently translated at 100.0% (8 of 8 strings) Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/it/

[IMP] pos_session_pay_invoice: Restrict to journals of the current PO…

bbc3b3a

…S session To prevent mistakes, users must select only the journals available in the pos.payment.method of the POS session.

[UPD] Update pos_session_pay_invoice.pot

d318667

[BOT] post-merge updates

19a4f16

Update translation files

1f39c58

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/

[UPD] Update pos_session_pay_invoice.pot

e54e159

[BOT] post-merge updates

e3fb61c

Update translation files

118ddd9

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/

Translated using Weblate (Italian)

5813ba8

Currently translated at 100.0% (12 of 12 strings) Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/it/

[IMP] pos_session_pay_invoice: pre-commit auto fixes

8b9c65f

Tisho99 force-pushed the 18.0-mig-pos_session_pay_invoice branch from 6dabf01 to 64477f2 Compare March 24, 2026 08:22

[MIG] pos_session_pay_invoice: Migration to 18.0

fd65042

Tisho99 force-pushed the 18.0-mig-pos_session_pay_invoice branch from 64477f2 to fd65042 Compare March 25, 2026 14:15

OCA-git-bot added the bot is merging ⏳ label Mar 25, 2026

OCA-git-bot merged commit 60ac10c into OCA:18.0 Mar 25, 2026
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 25, 2026

Uh oh!

Conversation

Tisho99 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javierizaca left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ValentinVinagre Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Tisho99 Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

ValentinVinagre Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Tisho99 Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ValentinVinagre left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Mar 19, 2026

Uh oh!

cristina-hidalgo-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

Tisho99 commented Mar 24, 2026

Uh oh!

pedrobaeza commented Mar 25, 2026

Uh oh!

Tisho99 commented Mar 25, 2026

Uh oh!

pedrobaeza commented Mar 25, 2026

Uh oh!

OCA-git-bot commented Mar 25, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Tisho99 commented Jan 12, 2026 •

edited

Loading

Tisho99 Jan 22, 2026 •

edited

Loading