Skip to content

[16.0][IMP] base_geoengine: Fix Vector Layer related Error#417

Open
anusriNPS wants to merge 1 commit intoOCA:16.0from
PyTech-SRL:16.0-fix-geoview
Open

[16.0][IMP] base_geoengine: Fix Vector Layer related Error#417
anusriNPS wants to merge 1 commit intoOCA:16.0from
PyTech-SRL:16.0-fix-geoview

Conversation

@anusriNPS
Copy link
Contributor

@anusriNPS anusriNPS commented Oct 8, 2025

Notifying user to define selected attribute_field_id of supported type from vector layer as part of geoengine view xml defintion which avoids below observed JS error.

image

@anusriNPS
Copy link
Contributor Author

anusriNPS commented Oct 8, 2025

Notification displayed when supported type of attribute_field_id is not available as part of geoengine view definition:
Screenshot from 2025-10-08 16-52-26

@anusriNPS anusriNPS changed the title [16.0][IMP] base_geoengine: Fix Vector Layer related Errors [16.0][IMP] base_geoengine: Fix Vector Layer related Error Oct 8, 2025
Copy link
Contributor

@HekkiMelody HekkiMelody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 22, 2026
@HekkiMelody
Copy link
Contributor

@OCA/geospatial-maintainers Could you please take a look? Thanks!

Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review only

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 1, 2026
@legalsylvain
Copy link
Contributor

/ocabot merge patch

could you port your patch upstream ? thanks !

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-417-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 9, 2026
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-417-by-legalsylvain-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

    Notifying user to define selected attribute_field_id of
supported type from vector layer as part of geoengine view
xml defintion which avoids observed JS error.
@anusriNPS
Copy link
Contributor Author

#442 Resolves pre-commit error seen due to recent changes in template

@HekkiMelody
Copy link
Contributor

/ocabot merge patch

could you port your patch upstream ? thanks !

Thank you for your time!

By "port upstream" you mean forward port to more recent versions of Odoo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants