[18.0][MIG] edi_exchange_deduplicate_oca: Migration to 18.0#242
[18.0][MIG] edi_exchange_deduplicate_oca: Migration to 18.0#242Ricardoalso wants to merge 9 commits intoOCA:18.0from
Conversation
Currently translated at 100.0% (12 of 12 strings) Translation: edi-framework-16.0/edi-framework-16.0-edi_exchange_deduplicate_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-16-0/edi-framework-16-0-edi_exchange_deduplicate_oca/it/
6e7bd0d to
fc8eda0
Compare
|
This PR has the |
| "author": "Camptocamp,Odoo Community Association (OCA)", | ||
| "maintainers": ["simahawk", "etobella"], | ||
| "website": "https://github.com/OCA/edi-framework", | ||
| "depends": ["edi_component_oca", "edi_queue_oca"], |
There was a problem hiding this comment.
Do you really need component and queue for this? can you handle the same only depending on edi_core_oca?
There was a problem hiding this comment.
Indeed, dependency confusion in a view. It is now corrected ✔️
Thanks @etobella !
fc8eda0 to
050ec1c
Compare
etobella
left a comment
There was a problem hiding this comment.
edi_component_oca is only used for testing. You can remove it by redoing the tests.
| # Copyright 2024 Camptocamp | ||
| # License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl). | ||
|
|
||
| from odoo.addons.edi_component_oca.tests.common import ( |
There was a problem hiding this comment.
You should redo the tests without edi_component_oca
There was a problem hiding this comment.
Tests are now refactored and the edi_component_oca dependecy is removed in a fixup commit ✔️
No description provided.