Skip to content

[18.0][MIG] edi_exchange_deduplicate_oca: Migration to 18.0#242

Open
Ricardoalso wants to merge 9 commits intoOCA:18.0from
camptocamp:18.0-mig-edi_exchange_deduplicate_oca_v2
Open

[18.0][MIG] edi_exchange_deduplicate_oca: Migration to 18.0#242
Ricardoalso wants to merge 9 commits intoOCA:18.0from
camptocamp:18.0-mig-edi_exchange_deduplicate_oca_v2

Conversation

@Ricardoalso
Copy link
Copy Markdown
Contributor

No description provided.

@Ricardoalso Ricardoalso force-pushed the 18.0-mig-edi_exchange_deduplicate_oca_v2 branch 2 times, most recently from 6e7bd0d to fc8eda0 Compare February 25, 2026 16:41
@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

"author": "Camptocamp,Odoo Community Association (OCA)",
"maintainers": ["simahawk", "etobella"],
"website": "https://github.com/OCA/edi-framework",
"depends": ["edi_component_oca", "edi_queue_oca"],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need component and queue for this? can you handle the same only depending on edi_core_oca?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, dependency confusion in a view. It is now corrected ✔️

Thanks @etobella !

@Ricardoalso Ricardoalso force-pushed the 18.0-mig-edi_exchange_deduplicate_oca_v2 branch from fc8eda0 to 050ec1c Compare April 14, 2026 07:53
@OCA-git-bot OCA-git-bot added mod:edi_exchange_deduplicate_oca Module edi_exchange_deduplicate_oca series:18.0 labels Apr 14, 2026
Copy link
Copy Markdown
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edi_component_oca is only used for testing. You can remove it by redoing the tests.

# Copyright 2024 Camptocamp
# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).

from odoo.addons.edi_component_oca.tests.common import (
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should redo the tests without edi_component_oca

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now refactored and the edi_component_oca dependecy is removed in a fixup commit ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants