[19.0][MIG] subscription_oca

[stferraro]

“Applied the requested test corrections as per review.”

[yvaucher]

/ocabot migration subscription_oca

[yvaucher]

@stferraro The commit history looks really weird, you need to keep the history of the module

I expect to see those commits:

https://github.com/OCA/contract/commits/17.0/subscription_oca

(translation commits can be merged)

Please find here the whole instructions for module migration: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0

[yvaucher]

Commit history is broken

[stferraro]

@yvaucher ok close this pr and open new with this change for migrate this module

[yvaucher]

You can push force on this one to fix it, no need to close it.

[stferraro]

@yvaucher check pr now !

[rickard-w]

Are you guys also having a look at reported bugs in previous versions when doing this migration?
I reported Bug #1320 - [17.0], [18.0] subscription_oca - Uncontrolled changes of discount on product lines.

Would be really appreciated if this weird behavior was taken care of in [19.0]

[stferraro]

"Hi @rickard-w, I have addressed the issue described in bug #1320.

I modified the _compute_discount logic to ensure that manual discounts are preserved when changing the product quantity. Additionally, I've added a new regression test test_manual_discount_persistence to verify the fix and prevent this from happening again in the future.

Could you please review and verify? Thanks!"

[rickard-w]

Thank you very much @stferraro.

I would love to help you with the verification, but I don't know how to test this when there's no Runbot, and I don't have the skills to verify the code. Sorry about that

[kwoychesko]

Thank you very much @stferraro.

I would love to help you with the verification, but I don't know how to test this when there's no Runbot, and I don't have the skills to verify the code. Sorry about that

Hey @rickard-w -- I was struggling with this, too. The workaround I'm using:

1. Find the v18.0 (or other prev version) of the module.
2. Click the Try Me! button. This opens up the runbot for that version.
3. Change the version number in the URL from "target_branch=18.0" to "target_branch=19.0" (for example).
4. The runbot for the 19.0 version opens.
5. Start the instance related to the PR (see red box in screenshot).

[rickard-w]

@stferraro I have done some basic testing of the Subscription now. As far as I can tell it works fine. Thanks for fixing bug #1320.

Thanks @kwoychesko for the Runbot instruction.

[stferraro]

please verify all and approved this pr please and merge to 19.0 branch

[rickard-w]

@stferraro In v17 I have added a Record Rule for multi company. Maybe that should be implemented in this version as this is standard in other odoo modules. Other than that I haven't found any discrepancies

[stferraro]

@rickard-w Thank you for the feedback.

Hello, I will add it to align this module with the standard approach used across Odoo and OCA modules.

This should ensure consistency and completeness regarding multi-company behavior.

Thanks again for pointing this out.

[stferraro]

@rickard-w

Thank you for the clarification.

I have reviewed both version 17 and 18, and I was not able to find any record rule related to multi-company in those implementations of the module.

Could you please point me to the specific PR or commit where this record rule was introduced, and in which part of the module it should be located?

This will help ensure the implementation is aligned correctly with the intended standard approach.

Thanks again for your support.

[stferraro]

@yvaucher please approved this PR and merge to 19.0

[rickard-w]

@ stferraro Sorry for misleading you. What I meant was that I have implemented the record rule in my local v17 installation. I'm a newbie to this so I don't know how to add stuff in here :)