Skip to content

Add camelCase json tags to model structs#184

Merged
tim-thacker-nullify merged 1 commit intomainfrom
add-json-tags
Feb 19, 2026
Merged

Add camelCase json tags to model structs#184
tim-thacker-nullify merged 1 commit intomainfrom
add-json-tags

Conversation

@tim-thacker-nullify
Copy link
Member

Summary

  • Add json struct tags alongside existing yaml tags to all model types in pkg/models/
  • JSON tags use camelCase convention, yaml tags remain snake_case
  • Enables proper JSON serialization for Python codegen in hyperdrive (avoids field name shadowing type names)

Test plan

  • go build ./... passes
  • go test ./... passes (all existing tests)

🤖 Generated with Claude Code

Add json struct tags alongside existing yaml tags to all model types.
This enables proper JSON serialization with camelCase field names while
preserving snake_case yaml serialization for config files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dnjg
Copy link
Member

dnjg commented Feb 19, 2026

is this just for serializing the config between services, or we want the config file format to actually support json now?

@tim-thacker-nullify
Copy link
Member Author

tim-thacker-nullify commented Feb 19, 2026

is this just for serializing the config between services, or we want the config file format to actually support json now?

yeah we use some models from here in the backend

@tim-thacker-nullify tim-thacker-nullify added this pull request to the merge queue Feb 19, 2026
Merged via the queue into main with commit c82801c Feb 19, 2026
2 of 3 checks passed
@tim-thacker-nullify tim-thacker-nullify deleted the add-json-tags branch February 19, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants