fix: prepend api. prefix in NullifyClient and use POST for metrics overview#135
Merged
jonathanlam merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
…erview NullifyClient and refreshingAuthTransport were constructing BaseURL without the api. prefix, and authTransport was overriding the request host back to the bare form. The status command was also using GET instead of POST for /admin/metrics/overview.
vik-nullify
approved these changes
Mar 18, 2026
tim-thacker-nullify
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseURLwithout theapi.prefix (e.g.https://x.nullify.aiinstead ofhttps://api.x.nullify.ai), causing TLS errors on all requests through the legacy clientBaseURL/admin/metrics/overview, which is a POST endpoint requiring a{"query":{}}bodyTest plan
nullify statusreturns full security posture overviewnullify reposlists repositoriesnullify findings --type sastreturns findingsmake unit)