fix: populate OTel resource attributes from env var#163
Merged
adamflorence-nullify merged 1 commit intomainfrom Mar 6, 2026
Merged
fix: populate OTel resource attributes from env var#163adamflorence-nullify merged 1 commit intomainfrom
adamflorence-nullify merged 1 commit intomainfrom
Conversation
…env var resource.New() was not using resource.WithFromEnv(), so resource attributes set via OTEL_RESOURCE_ATTRIBUTES (including nul.deployment_id and deployment.environment) were never attached to the OTel resource. This meant they appeared on target_info but not on any application metric (nul_pipeline_event_total, nul_scan_duration_seconds, etc.), making per-customer metric queries impossible. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tim-thacker-nullify
approved these changes
Mar 6, 2026
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resource.New()inconfigureOTel()was missingresource.WithFromEnv(), so resource attributes set viaOTEL_RESOURCE_ATTRIBUTES(includingnul.deployment_idanddeployment.environment) were never attached to the OTel resource.This meant they appeared on
target_info(resource metadata) but not on any application metric (nul_pipeline_event_total,nul_scan_duration_seconds, etc.), making per-customer metric queries impossible.Impact: Once deployed, all
nul_*metrics will gainnul_deployment_idas a label, enabling per-customer alerting (e.g. pipeline volume drop/spike alerts) and dashboarding.Test Plan
go build ./...passesgo test ./pkg/logger/... -shortpassesnul_deployment_idappears on application metrics in Prometheus (not justtarget_info)group by (nul_deployment_id) (nul_pipeline_event_total{deployment_environment="prod", nul_deployment_id!=""})Checklist