refator: dedup logger configuration between dev and prod#155
Merged
gidonkessler-nullify merged 1 commit intomainfrom Feb 11, 2026
Merged
refator: dedup logger configuration between dev and prod#155gidonkessler-nullify merged 1 commit intomainfrom
gidonkessler-nullify merged 1 commit intomainfrom
Conversation
jonathanlam
approved these changes
Feb 11, 2026
vik-nullify
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As I was looking through some of the code I noticed there was duplicated code over these 2 adjacent functions so I thought it would be a good exercise to go through the PR process on a small change