fix(macos): make GraalVM Mach-O post-processing safe with validation and rollback (#247)#248
Open
RavenLiao wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description
Refactored macOS GraalVM post-processing to use a safe, transactional mutation flow instead of destructive in-place edits.
Main changes:
SafeMachOFileMutationhelper for copy → mutate → validate → replace flow.vtool) to use safe mutation + validation (otool -l,vtool -show-build).stripDylibsto per-file Kotlin processing via the same safe path.📄 Motivation and Context
Fixes macOS packaging issue #247 where in-place Mach-O mutation could leave corrupted binaries inside
.appbundles when tool execution failed.This change ensures:
🧪 How Has This Been Tested?
Local verification (Windows/static):
./gradlew :plugin-build:plugin:test --tests "io.github.kdroidfilter.nucleus.desktop.application.internal.SafeMachOFileMutationTest" --tests "io.github.kdroidfilter.nucleus.desktop.application.tasks.AotArgFileSupportTest"./gradlew :plugin-build:plugin:checkAdded tests cover:
Note:
vtool/otool/codesign/stripstill needs a macOS environment.📦 Types of changes
✅ Checklist