Skip to content

Improvement/bios test#275

Open
RaiBnod wants to merge 5 commits intomasterfrom
improvement/bios-test
Open

Improvement/bios test#275
RaiBnod wants to merge 5 commits intomasterfrom
improvement/bios-test

Conversation

@RaiBnod
Copy link
Copy Markdown
Member

@RaiBnod RaiBnod commented Oct 23, 2019

Resolves: #256

@RaiBnod RaiBnod requested a review from zero88 October 23, 2019 08:07
Copy link
Copy Markdown
Contributor

@zero88 zero88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaiBnod your commit does not follow my skeleton and you change class modifier, it is not my request.
I asked

  • extend BaseInstallerVerticleTest
  • extend MockDeploymentService
  • extend MockFinisherService
    See ticket description again

This test still depends on timer and it is not my expectation and you also have not yet understand deeply what behind.
I want to see asserting response something like:

INSTALLER::Finish deployment::{"service_id":"com.nubeiot.edge.connector:bacnet","transaction_id":"59231d79-9d47-4895-98c0-f74d4ef930fa","deploy_id":"ffcd3bf2-4a09-40a4-92c7-b013eefc61c6","action":"CREATE","prev_state":"NONE","to_state":"ENABLED","to_actual_state":"ENABLED","status":"SUCCESS","error":{},"affect_records":2}

@zero88 zero88 force-pushed the master branch 2 times, most recently from f2047b4 to 68d3fa8 Compare February 6, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Bios test is great and green again

2 participants