Open
Conversation
zero88
suggested changes
Nov 7, 2019
Contributor
zero88
left a comment
There was a problem hiding this comment.
@RaiBnod your commit does not follow my skeleton and you change class modifier, it is not my request.
I asked
extend BaseInstallerVerticleTestextend MockDeploymentServiceextend MockFinisherService
See ticket description again
This test still depends on timer and it is not my expectation and you also have not yet understand deeply what behind.
I want to see asserting response something like:
INSTALLER::Finish deployment::{"service_id":"com.nubeiot.edge.connector:bacnet","transaction_id":"59231d79-9d47-4895-98c0-f74d4ef930fa","deploy_id":"ffcd3bf2-4a09-40a4-92c7-b013eefc61c6","action":"CREATE","prev_state":"NONE","to_state":"ENABLED","to_actual_state":"ENABLED","status":"SUCCESS","error":{},"affect_records":2}
f2047b4 to
68d3fa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #256