Skip to content

Fix GH Pages not loading correctly for rsisec.lat #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RHV044 merged 2 commits into from
Mar 31, 2026
Merged

Fix GH Pages not loading correctly for rsisec.lat #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9f2412
Initial plan
Copilot Mar 31, 2026
9d3a381
fix: set Vite base to '/' for custom domain, add CNAME to public/, fi…
Copilot Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="es">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/rsi-web/favicon.svg" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using Vite’s %BASE_URL% placeholder for the favicon URL (e.g., %BASE_URL%favicon.svg) instead of a hardcoded root path. This keeps the favicon working if base is ever changed again (e.g., for non-custom-domain deployments) and avoids reintroducing path-related 404s.

Suggested change
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" type="image/svg+xml" href="%BASE_URL%favicon.svg" />

Copilot uses AI. Check for mistakes.
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta name="description" content="RSI Argentina - Empresa de seguridad privada. Vigilancia física, tótems de seguridad, monitoreo CCTV y control de accesos." />
<title>RSI Argentina | Seguridad Privada</title>
Expand Down
1 change: 1 addition & 0 deletions public/CNAME
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
rsisec.lat
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a CNAME file at the repo root, and this PR adds another one under public/. Since only public/CNAME will be emitted into dist/ by Vite, consider removing the root-level CNAME (or documenting which one is authoritative) to avoid future confusion about the actual Pages custom-domain source of truth.

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ import react from '@vitejs/plugin-react'
// https://vite.dev/config/
export default defineConfig({
plugins: [react()],
base: '/rsi-web/',
base: '/',
})
Loading