fix: add defensive check for undefined uuid in uuidToId#703
Open
ehredev wants to merge 2 commits intoNotionX:masterfrom
Open
fix: add defensive check for undefined uuid in uuidToId#703ehredev wants to merge 2 commits intoNotionX:masterfrom
ehredev wants to merge 2 commits intoNotionX:masterfrom
Conversation
Notion API response structure changes can cause block IDs to be undefined in some cases, leading to `undefined.replaceAll()` errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
This issue is regarding #702 |
Notion API now returns some blocks with a doubly-nested structure:
{ role, value: { role, value: { id, type, ... } } }
Flatten these right after receiving the recordMap so downstream code
can access block properties directly.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
upgrade my notion libraries to the latest one solved the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion API response structure changes can cause block IDs to be undefined in some cases, leading to
undefined.replaceAll()errors.Description
uuidToId could crash with undefined.replaceAll() when Notion API returns blocks with undefined IDs due to their recent response structure changes. Added a simple fallback (uuid || '') to prevent the error.