Skip to content

language/docker: init#1431

Open
snoweuph wants to merge 2 commits intoNotAShelf:mainfrom
snoweuph:feat/docker
Open

language/docker: init#1431
snoweuph wants to merge 2 commits intoNotAShelf:mainfrom
snoweuph:feat/docker

Conversation

@snoweuph
Copy link
Copy Markdown
Collaborator

@snoweuph snoweuph commented Feb 27, 2026 •
edited
Loading

Adds support for docker, docker compose and also docker in terraform.

most if it was already created in #1104.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

snoweuph
snoweuph commented Feb 27, 2026
View reviewed changes
Comment thread modules/plugins/languages/docker.nix Outdated
snoweuph
snoweuph commented Feb 27, 2026
View reviewed changes
Comment thread modules/plugins/languages/docker.nix
github-actions Bot pushed a commit that referenced this pull request Feb 27, 2026
@actions-user
Deploy PR #1431 preview
5b94e93
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 27, 2026 •
edited
Loading

🚀 Live preview deployed from 5b4f9c6

View it here:

Debug Information

Triggered by: snoweuph

HEAD at: feat/docker

Reruns: 2823

@snoweuph snoweuph force-pushed the feat/docker branch 2 times, most recently from 3b5abee to c6cdb87 Compare February 27, 2026 20:19
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Mar 19, 2026

rebased for my sanity

github-actions Bot pushed a commit that referenced this pull request Mar 21, 2026
@actions-user
Deploy PR #1431 preview
eb9280d
github-actions Bot pushed a commit that referenced this pull request Mar 21, 2026
@actions-user
Deploy PR #1431 preview
2ae2fc8
@snoweuph snoweuph added the TBD More discussion and research is in order label Mar 28, 2026
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Mar 29, 2026 •
edited
Loading

I'm already using this in my nvf based config:

But as this requires a ftdetect to work correctly, this wont get merged any time soon, because we don't include those in nvf, but there is work on an new API for exactly this in: #1365.
till then I will rebase this from time to time...

So for anybody that wants docker support in their config, feel free to steal my config, as long as you're human.

@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Apr 7, 2026

rebased

@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Apr 19, 2026

rebased

github-actions Bot pushed a commit that referenced this pull request Apr 19, 2026
@actions-user
Deploy PR #1431 preview
5583fc1
@snoweuph snoweuph force-pushed the feat/docker branch 3 times, most recently from d804d8d to 3daaa3e Compare April 19, 2026 00:53
snoweuph
snoweuph commented Apr 19, 2026
View reviewed changes
Comment thread modules/plugins/languages/docker.nix
config = mkMerge [
{
vim.autocmds = [
# Without this the LSP doesn't understand them correctly
Copy link
Copy Markdown
Collaborator Author

@snoweuph snoweuph Apr 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno when #1365 will be merged...
(it supposed to introduce a new filetypes API)

So I'm adding in the autocommand as that is what works with nvf how it is rn

@snoweuph snoweuph marked this pull request as ready for review April 19, 2026 00:56
@snoweuph snoweuph requested a review from NotAShelf as a code owner April 19, 2026 00:56
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Apr 19, 2026

rebased

github-actions Bot pushed a commit that referenced this pull request Apr 19, 2026
@actions-user
Deploy PR #1431 preview
a0345e1
github-actions Bot pushed a commit that referenced this pull request Apr 19, 2026
@actions-user
Deploy PR #1431 preview
2b5f338
github-actions Bot pushed a commit that referenced this pull request Apr 19, 2026
@actions-user
Deploy PR #1431 preview
be19704
github-actions Bot pushed a commit that referenced this pull request Apr 20, 2026
@actions-user
Deploy PR #1431 preview
bdd66e3
github-actions Bot pushed a commit that referenced this pull request Apr 22, 2026
@actions-user
Deploy PR #1431 preview
ca6b195
github-actions Bot pushed a commit that referenced this pull request Apr 23, 2026
@actions-user
Deploy PR #1431 preview
26c390f
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Apr 24, 2026

rebased

github-actions Bot pushed a commit that referenced this pull request Apr 24, 2026
@actions-user
Deploy PR #1431 preview
2ea6bb9
github-actions Bot pushed a commit that referenced this pull request Apr 25, 2026
@actions-user
Deploy PR #1431 preview
b27f787
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Apr 25, 2026

rebased

@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented May 1, 2026

rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NotAShelf NotAShelf Awaiting requested review from NotAShelf NotAShelf is a code owner

@horriblename horriblename Awaiting requested review from horriblename horriblename is a code owner

@Soliprem Soliprem Awaiting requested review from Soliprem Soliprem is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

TBD More discussion and research is in order topic: documentation topic: modules topic: plugins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@snoweuph