Set expectation for example_nordvpnlite_config.json#1565
Open
gindoslaw wants to merge 1 commit intoNordSecurity:mainfrom
Open
Set expectation for example_nordvpnlite_config.json#1565gindoslaw wants to merge 1 commit intoNordSecurity:mainfrom
gindoslaw wants to merge 1 commit intoNordSecurity:mainfrom
Conversation
Add small message for the nordvpnlite users
|
|
tomasz-grz
reviewed
Nov 20, 2025
| @@ -1,3 +1,7 @@ | |||
| # This file is not for copy&paste | |||
Contributor
There was a problem hiding this comment.
Unfortunately JSON format does not support file comments.
And would also cause test_config_example to fail. which is there only to make sure the example config is updated and valid..
The main question is if we actually need example_nordvpnlite_config.json, maybe better documentation instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a small message for the nordvpnlite users.
Problem
example_nordvpnlite_config.json may be a temptation for a copy-paste. Settings are good for software engineers, but also are the trap for new users.
Solution
Add warning at the beginning of the file and point user to the alternative file used in OpenWRT package.