text-engine: 0.1.1 -> 0.1.1-unstable-2024-09-16

[paveloom]

Fixes #368664.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[dibenzepin]

would it make sense to add a mention to mjakeman/text-engine#40 all like "todo: revert back to a stable release once this gets dealt with"?

[paveloom]

@poopsicles For your last point: that's what's usually done anyway.

[dibenzepin]

@paveloom aight, i was trying to make an overlay for this because of #369069 and ended up with:

  nixpkgs.overlays = [
    (final: prev: {
      # until #369058 gets merged: https://nixpk.gs/pr-tracker.html?pr=369058
      text-engine = prev.text-engine.overrideAttrs (old: {
        src = prev.fetchFromGitHub {
          owner = "mjakeman";
          repo = "text-engine";
          rev = "4c26887556fd8e28211324c4058d49508eb5f557";
          hash = "sha256-0rMBz2s3wYv7gZiJTj8rixWxBjT6Dd6SaINP8kDbTyw=";
        };
        patches = [];
      });
    });
  ];

but in the process of doing so realised that text-engine isnt used anymore by it (hence, modifying buildInputs to swap it out here).

it also doesn't appear to be used by any other package in nixpkgs (i think):

$ cd nixpkgs
$ grep -ri "text-engine" *
pkgs/by-name/gn/gnome-extension-manager/package.nix:  text-engine,
pkgs/by-name/gn/gnome-extension-manager/package.nix:    text-engine
pkgs/by-name/te/text-engine/package.nix:  pname = "text-engine";
pkgs/by-name/te/text-engine/package.nix:      url = "https://github.com/mjakeman/text-engine/commit/749c94d853c0b0e29e79a1b270ec61947b65c319.patch";
pkgs/by-name/te/text-engine/package.nix:    mainProgram = "text-engine-demo";
pkgs/by-name/te/text-engine/package.nix:    homepage = "https://github.com/mjakeman/text-engine";

[paveloom]

You are correct, it is indeed not needed anymore for Gnome Extension Manager, and also isn't used anywhere else in Nixpkgs. It might still be okay to keep it, though.

[Atemu]

Otherwise intent and diff LGTM.

[ghost]

mjakeman/text-engine#40 has this from gnome-extension-manager's author:

Unfortunately my plans for a GTK native rich text editor never really panned out, and I don't have the time to maintain this library anymore.

I have a mostly finished rewrite in Zig that lives in-tree inside my game engine, but due to distribution problems with Zig (e.g. it still doesn't run on Asahi Linux), it's not suitable for Extension Manager which makes that a bit of a dead end.

Re: Extension Manager, my plan is to inline a simple HTML viewer into it and deprecate this library from the next release

The README states:

The library is under heavy development and generally not suitable for use in applications.

It would be better if text-engine is deprecated and removed since it's an individual library being used by the package author only. (specifically for the program https://github.com/mjakeman/bluetype which is unmaintained atm). So when #369069 is merged, text-engine should be removed next or at least marked as broken due to the newer compiler.

[Atemu]

This fixes the build:

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369058

---

x86_64-linux

✅ 1 package built:

• text-engine

[nixpkgs-ci]

Successfully created backport PR for release-25.05:

• [Backport release-25.05] text-engine: 0.1.1 -> 0.1.1-unstable-2024-09-16 #408034