nixos/howdy: init#216245
Conversation
|
I don't have the HW to test this. |
762e062 to
7a200d4
Compare
doronbehar
left a comment
There was a problem hiding this comment.
Sorry for more comment that could have been given earlier.
|
Hello guys. Please if you plan to apply commits can you please switch the PR to draft state? Otherwise our mailboxes will be filled by a lot of notification emails. Thanks |
doronbehar
left a comment
There was a problem hiding this comment.
Last comments so it seems!
doronbehar
left a comment
There was a problem hiding this comment.
One last review comment indeed!
|
|
OK great. I think you can squash the commits as discussed before. We are still waiting for a reply by @Majiir in #216245 (comment) , or perhaps somebody else that is confident enough with PAM in NixOS. Since that thread is hard to find due to the large amount of commits here, I wrote it in the top level comment. |
Majiir
left a comment
There was a problem hiding this comment.
PAM changes look good to me.
I suggest testing to double-check that the required control behaves as expected with Howdy. If a failure with Howdy interacts poorly with password prompts, you might need to use requisite. Howdy itself ships with a rule that uses [success=end default=ignore], which is pretty much sufficient - but that seems to contradict their own guidance to not use Howdy as the only auth method.
I can't make a good recommendation for the default here because I don't use face recognition and I don't know what users expect. But I'm happy to advise on any PAM changes in case you need to reorder the rule or anything.
We might need to in the future when linux-enable-ir-emitter ships v7.0.0. https://github.com/emixampp/linux-enable-ir-emitter?tab=readme-ov-file#integration-with-howdy |
I've tested this with my lock screen: Control Looks like it behaves like 2FA with these two control flags. IMO it's a good default, though it might confuse users. I'll make a note of it in the howdy module. |
|
@fufexan please squash the commits as we discussed earlier. Note also the target branch of the PR has changed. |
|
|
The test failures seem completely unrelated. I wonder why nixpkgs-review decided to build them... |
|
sorry for the ping, but woop woop <3 |
|
Just a small heads-up: for me it was necessary to remove the face-data I created during testing, and re-add otherwise authentication failed despite the password being correct. |
|
heyho, i have a howdy pam behaviour i didnt had before i switched to the nixos-unstable version from your fork. but its not turning off. I also had the problem at some point that i was not able to login at all with an pam failure, but im not able to rebuild that error currently... Oh and the autounlock of my kdewallet is also not working anymore :/ |
|
Try: |
|
Trying to use this but greetd requires both a password and the facial recognition to login. I don't really need this level of security on my home desktop. I have 'security.pam.services.greetyd.howdy.control = "sufficient"' - am I missing something? |
|
You have a typo. should be - security.pam.services.greetyd.howdy.control = "sufficient"
+ security.pam.services.greetd.howdy.control = "sufficient" |
Ah thanks, though I must have been half asleep when I wrote this. I realised I was actually testing it against the noctalia lock screen rather than greetd. Not quite sure how to get this configured. |
Description of changes
Adds Howdy as a service.
TODO:
Fixes #76928
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)closes #344024