fix: pass issue context through template context instead of ad-hoc model attributes

[abdella-h]

Problem

get_context_data() attached suggestion_context and github_issue directly onto NixpkgsIssue model instances — fields that don't exist on the model. This only worked accidentally because Django templates use object.__dict__ internally.

Fix

Build an explicit issue_contexts list of dictionaries and pass it through the template context properly. Update issue_list.html to
iterate over issue_contexts instead of object_list.

[florentc]

Thank you for your contribution. You are very close to the pattern we use for most of the suggestion-related templates, so as a step towards more consistency could you please go one step further and fit the pattern in question? By this I mean define an IssueContext type and have the issue component take only one parameter, data of type IssueContext, and then use the various data.this or data.that in the issue template.

[abdella-h]

@florentc Thanks for the feedback. I've updated the PR to use an IssueContext type following the same pattern as SuggestionContext

[florentc]

This belongs alongside the issue view. Please either move the issue view from the global views.py to its specific directory like for suggestions, or just define IssueContext alongside the view. You defined the type with the suggestions here.

[abdella-h]

I moved IssueContext to views.py

[florentc]

Suggested change

	{% for data in issue_contexts %}
	{% issue data show_permalink=True %}
	{% for issue_context in issue_contexts %}
	{% issue issue_context %}

Please move show_permalink to the issue_context too

[florentc]

Please move show_permalink to the issue_context too (this should just have data as a parameter in the end, and set it in the view

[abdella-h]

The IssueContext now includes show_permalink, and the {% issue %} tag only takes data as a parameter

[florentc]

Could you solve the build issues?