Add Create dough to Farm & Charm dough conversion#29
Open
RooftopThinker wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a compatibility recipe that allows dough items tagged as
#c:foods/doughto be converted into Farm & Charm dough by adding Farm & Charm yeast.Added recipe:
#c:foods/dough+farm_and_charm:yeast->5x farm_and_charm:doughThe recipe uses Farm & Charm's
crafting_bowlrecipe type, so the conversion stays within Farm & Charm's cooking workflow instead of becoming a generic vanilla crafting recipe.Motivation
This recipe is based on the existing common tag system rather than on hardcoded item-specific conversions.
Items in
#c:foods/doughare already exposed by their respective mods as common dough items intended for cross-mod recipe compatibility. Farm & Charm also treats its dough as a generic dough item rather than splitting it by grain type.Because Farm & Charm dough requires yeast, this recipe does not make external dough items equivalent to Farm & Charm dough for free. Instead, it allows common dough items to be upgraded into Farm & Charm dough through Farm & Charm's own
crafting_bowlworkflow by addingfarm_and_charm:yeast.This follows the general purpose of conventional/common tags: reducing inconsistency between mods and allowing equivalent content to be used interchangeably where appropriate.
Reference:
https://wiki.fabricmc.net/tutorial:tags#conventional_tags
Notes
This PR does not:
The recipe is conditionally loaded when Farm & Charm is present.
Testing