Add three-layer test structure and embedded skill resource#3
Open
mgoldsborough wants to merge 1 commit intomainfrom
Open
Add three-layer test structure and embedded skill resource#3mgoldsborough wants to merge 1 commit intomainfrom
mgoldsborough wants to merge 1 commit intomainfrom
Conversation
- Add unit tests: test_server.py (FastMCP Client pattern), test_api_client.py, shared conftest.py with mcp_server and mock_client fixtures - Add integration test scaffolding (tests-integration/) with env gating, tier-skip helpers, and LLM smoke test stubs - Add SKILL.md embedded skill resource with tool table and workflows - Wire skill resource in server.py (instructions + skill:// URI) - Add test-integration and test-llm Makefile targets - Fix type ignore comment and import sorting
mgoldsborough
force-pushed
the
add-test-layers
branch
from
f6846c9 to
b63fde4
Compare
JoeCardoso13
approved these changes
Mar 5, 2026
Contributor
JoeCardoso13
left a comment
JoeCardoso13
left a comment
There was a problem hiding this comment.
This fixes a bump in the build-mcpb pipeline. Specifically Phase 4, where:
"SKILL.md missing caused all server tests to fail. The server reads SKILL.md at module import time (files("mcp_todoist").joinpath("SKILL.md").read_text()). Since Phase 6 hadn't happened yet, the file didn't exist, and every test that imported mcp_todoist.server crashed with FileNotFoundError." The agent created the line on server.py that reads the SKILL.md based on the canonical structure found in PATTERNS.md, so now, with this PR, the template will adequate itself to the canonical structure described in the references/ of the skill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_server.py,test_api_client.py, sharedconftest.py)tests-integration/) with env gating, tier-skip helpers, and LLM smoke test stubsSKILL.mdskill resource with tool table and workflows, wired viaskill://example/usagetest-integrationandtest-llmMakefile targetstype: ignorecomment and import sortingTest plan
make checkpasses (25 unit tests, format, lint, typecheck)make test-integrationworks with a real API keymake test-llmworks with ANTHROPIC_API_KEY