Fix broken CI, scan workflow, and add local bundle target#2
Merged
mgoldsborough merged 4 commits intomainfrom Mar 5, 2026
Merged
Fix broken CI, scan workflow, and add local bundle target#2mgoldsborough merged 4 commits intomainfrom
mgoldsborough merged 4 commits intomainfrom
Conversation
Contributor
Author
|
PR covers template issues 1-4 at the bottom of NimbleBrainInc/contributor-toolkit#21 (comment) |
Contributor
|
CI is broken. |
mgoldsborough
requested changes
Mar 4, 2026
mgoldsborough
previously approved these changes
Mar 5, 2026
- ci.yml: replace `pip install mcpb && mcpb pack` with `npx @anthropic-ai/mcpb pack` (mcpb is an npm package, not pip) - scan.yml: fix mcpb install, make mpak-scanner step skip gracefully since mpak-scanner is not yet an installable package (scanning happens server-side) - pyproject.toml: fix ty version constraint (0.1.0 doesn't exist, use 0.0.17) - Makefile: add `bundle` target for local bundle creation (vendors deps + mcpb pack) - .gitignore/.mcpbignore: add deps/ directory used by bundle target Closes #1
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mgoldsborough
force-pushed
the
fix-broken-ci-and-bundle
branch
from
64d3241 to
cb507b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.ymlbundle job:pip install mcpb→npx @anthropic-ai/mcpb pack(mcpb is npm, not pip)scan.yml: graceful skip when mpak-scanner isn't available yetpyproject.toml: ty>=0.1.0 doesn't exist → ty>=0.0.17make bundletarget for local bundle validationdeps/to .gitignore and .mcpbignoreCloses #1
Test plan
make bundleproduces a.mcpbfile locallymake checkpasses (lint, typecheck, test)