Updates to prevent Swift 5.0 deprecation warnings#7
Open
cliss wants to merge 1 commit intoNikolaiRuhe:masterfrom
Open
Updates to prevent Swift 5.0 deprecation warnings#7cliss wants to merge 1 commit intoNikolaiRuhe:masterfrom
cliss wants to merge 1 commit intoNikolaiRuhe:masterfrom
Conversation
|
Hi @cliss, We tried importing your changes in our own PR on SPM support. This branch uses Xcode 11.2.1 with swift 5.1.2. We did not included it because the following showed up:
It seems your changes are affecting the way the hash is computed, at least when using swift 5.1.2. We don't have the time to look into this so we are staying with the warnings, but we thought you should know since your implementation might be broken if you upgrade to swift 5.1.2/Xcode 11.2.1. Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using
SwiftDigestin my own project; thank you! This PR is to remove some deprecation warnings that cropped up as a part of the Swift 5.0 update.This does seem to be working properly for me, but I strongly advise some independent testing to be sure I didn't mess something up. 😆