Skip to content

Cleanup for game-pillarsofeternity2#21547

Merged
erri120 merged 7 commits intoNexus-Mods:masterfrom
wxMichael:game-pillarsofeternity2
Mar 18, 2026
Merged

Cleanup for game-pillarsofeternity2#21547
erri120 merged 7 commits intoNexus-Mods:masterfrom
wxMichael:game-pillarsofeternity2

Conversation

@wxMichael
Copy link
Copy Markdown
Contributor

  • Moved game-pillarsofeternity2/ from extensions/ to extensions/games/
  • Added config so the extension displays as Game: Pillars of Eternity 2: Deadfire instead of Game Pillarsofeternity2
  • Made package.json entries consistent with other extensions like Stardew Valley.
    The only change I'm unsure of is "main": ./out/index.js -> dist/index.js

@wxMichael
Copy link
Copy Markdown
Contributor Author

wxMichael commented Mar 15, 2026

It seems like package.json's main variable is no longer used. Guessing it's from an old build setup?
If so I'd like to clean all those up.

Edit: @erri120 confirmed main isn't used in the extensions as they aren't typical packages, so I removed them in #21557

@github-actions
Copy link
Copy Markdown

This PR has conflicts. You need to rebase the PR before it can be merged.

@github-actions
Copy link
Copy Markdown

This PR doesn't have conflicts anymore. It can be merged after all status checks have passed and it has been reviewed.

@github-actions
Copy link
Copy Markdown

This PR has conflicts. You need to rebase the PR before it can be merged.

@github-actions
Copy link
Copy Markdown

This PR doesn't have conflicts anymore. It can be merged after all status checks have passed and it has been reviewed.

@erri120 erri120 requested a review from a team March 18, 2026 17:06
@erri120 erri120 merged commit a031683 into Nexus-Mods:master Mar 18, 2026
5 checks passed
@wxMichael wxMichael deleted the game-pillarsofeternity2 branch March 19, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants