Merged
Conversation
Values from src\stylesheets\variables.scss
Needed for replaceAll and regex flags
The behavior of onChange and onChangeComplete seems to be reversed, so switched to the former.
Fixes incorrect/invalid hex colors in the UI
Also makes colors visible in VS Code
Color pickers aren't used anywhere outside of theme-switcher
wxMichael
force-pushed
the
theme-switcher-fixes
branch
from
82158bd to
016b460
Compare
IDCs
approved these changes
Mar 19, 2026
Contributor
|
Hey @wxMichael - going to merge this in as it can't hurt, but please note that I'm unsure of how this extension is going to develop in the future given UIV2 changes - I'm assuming it will get re-written entirely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a number of issues with theme-switcher:
Fixes #19323
Themed color picker:
Error when cloning Contrast theme: