Add 5 new SSVEP classifiers and fix label handling#1009
Merged
bruAristimunha merged 10 commits intodevelopfrom Mar 1, 2026
Merged
Add 5 new SSVEP classifiers and fix label handling#1009bruAristimunha merged 10 commits intodevelopfrom
bruAristimunha merged 10 commits intodevelopfrom
Conversation
…lines
Add SSVEP_itCCA, SSVEP_eCCA, SSVEP_TRCA_R, SSVEP_SSCOR, and SSVEP_TDCA
classifiers with pipeline YAML configs, benchmark registration, and tests.
Fix critical label mismatch in all SSVEP classifiers: previously used
X.event_id.keys() which returned generic integer strings ('1','2',...)
instead of actual frequency labels from y ('9.25','9.75',...). This caused
wrong sinusoidal reference frequencies, wrong filterbank peaks, and
prediction/evaluation label mismatches. Now all classifiers use np.unique(y)
and boolean masking for epoch selection, matching MsetCCA's correct pattern.
Also fix filterbank numerical stability (SOS form, capped filter order)
and np.reshape deprecation in ssvep_nakanishi.py and ssvep_wang.py.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
np.reshapedeprecation inssvep_nakanishi.pyandssvep_wang.pyLabel handling fix
All SSVEP classifiers (except MsetCCA) used
X.event_id.keys()to get class labels, which returned generic integer strings ('1','2', ...) instead of actual frequency labels fromy('9.25','9.75', ...). This caused:Now all classifiers use
np.unique(y)and boolean masking for epoch selection. The benchmark also passesmne_labels=Truefor epoch-based pipelines.Benchmark results (Nakanishi2015, WithinSession, 12-class)
Test plan