Skip to content

refactor(qbft): introduce QbftTypes and some function structs #431

Merged
iamquang95 merged 37 commits into
mainfrom
iamquang95/refactor-qbft
May 22, 2026
Merged

refactor(qbft): introduce QbftTypes and some function structs #431
iamquang95 merged 37 commits into
mainfrom
iamquang95/refactor-qbft

Conversation

@iamquang95
Copy link
Copy Markdown
Collaborator

@iamquang95 iamquang95 commented May 21, 2026 •
edited
Loading

Part of: #393

This PR:

  • Introduce QbftTypes for QBFT associated types.
  • Replace tuple-style callbacks with typed request structs.
  • Move callback boundary types into qbft/callbacks.rs.
  • Remove broad mod.rs lint allows.

iamquang95 added 30 commits May 14, 2026 11:16
@iamquang95
test: update qbft test
606d5bc
@iamquang95
fix: compare run on retached thread
0ec38de
@iamquang95
fix: removed hard coded salt in tests
b752caa
@iamquang95
fix: return error on Context cancelled
ed912ee
@iamquang95
fix: hash from string, not magic number
e01f64f
@iamquang95
fix: one shot cancel when parent is cancelled
b22fb41
@iamquang95
fix: fix make_is_leader test
081d8a4
@iamquang95
fix: minors naming and comments
1a0a337
@iamquang95
Merge remote-tracking branch 'origin/main' into iamquang95/qbft
183f48e
@iamquang95
fix: linter
44b9a13
@iamquang95
fix: early cancel on the loop
cc59baf
@iamquang95
fix: context cancel in compare
ed82b6e
@iamquang95
fix: validate definition
7911c23
@iamquang95
fix: add check pr < r
829ba5f
@iamquang95
fix: test and document on run
d834463
@iamquang95
fix: compare callback failed should timeout
739e3b3
@iamquang95
fix: test use timeout channel instead of sleep
27744cf
@iamquang95
fix: add comment on cancellation poll interval
0bd6a4f
@iamquang95
fix: use enum for invalid defnintion error
e988c35
@iamquang95
fix: add more test on check valid round
6c65b32
@iamquang95
fix: using test-case
b30e616
@iamquang95
fix: small fixes
4a364df
@iamquang95
fix: linter
e759a81
@iamquang95
Merge remote-tracking branch 'origin/main' into iamquang95/qbft
2d9ef3c
@iamquang95
fix: remove unnecessary filter
998b9ce
@iamquang95
fix: make_is_leader now 0-based
0451f20
@iamquang95
fix: add cancelled state for fake clock
e0e51f7
@iamquang95
fix: flanky tests by ordering and add small settle window time
6cc22da
@iamquang95
fix: harden fake-clock to avoid flanky scheduling
7e48b56
@iamquang95
fix: lint
024bff7
therustmonk
therustmonk reviewed May 21, 2026
View reviewed changes
Comment thread crates/core/src/qbft/mod.rs
+ Send
+ Sync,
>,
pub broadcast: Box<BroadcastFn<T>>,
Copy link
Copy Markdown
Collaborator

@therustmonk therustmonk May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent cleanup

Base automatically changed from iamquang95/qbft to main May 22, 2026 13:18
@iamquang95
Merge remote-tracking branch 'origin/main' into iamquang95/refactor-qbft
8170a5d 
# Conflicts:
#	crates/core/src/qbft/fake_clock.rs
#	crates/core/src/qbft/internal_test.rs
#	crates/core/src/qbft/mod.rs
@iamquang95 iamquang95 merged commit a4792e0 into main May 22, 2026
11 checks passed
@iamquang95 iamquang95 deleted the iamquang95/refactor-qbft branch May 22, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@therustmonk therustmonk therustmonk approved these changes

@varex83 varex83 varex83 approved these changes

@mskrzypkows mskrzypkows Awaiting requested review from mskrzypkows

@emlautarom1 emlautarom1 Awaiting requested review from emlautarom1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iamquang95 @therustmonk @varex83