fix: update requirements-rocm.txt for Windows support via AMD TheRock nightly#1385
fix: update requirements-rocm.txt for Windows support via AMD TheRock nightly#1385titansonico10 wants to merge 1 commit intoNerogar:masterfrom
Conversation
…htly - Replace rocm6.3 wheels (Linux-only) with TheRock nightly index per RDNA architecture - Add per-architecture find-links URLs for RDNA2/3/4 (gfx103X/110X/120X) - Remove onnxruntime ROCm EP (dropped since ORT 1.23, last supported ROCm 7.0) - Tested on Windows 11 with RX 9060 XT (gfx1200) and ROCm 7.13.0a20260318 Fixes Nerogar#1381
|
Closing this PR in favor of a narrower Windows-only follow-up. The current version changes I’ll open a new PR that:
|
|
Please dont, there is already ongoing modernisation of the installation #1244 because Windows + ROCM installation cannot be automated it requires user intervention. It will be wasted effort on your part. If you can describe exactly how and AMD user should determine what GPU they have, then exactly what to install, we can create a small helper script in the installer that detects if you are Win+AMD and links to documentation on exactly how to do that |
|
@titansonico10 oops forgot to ping, please see above message |
|
Thanks @O-J1 for the heads up about #1244. I wasn't aware of the ongoing pixi-based installation work. Here's the exact info you asked for, in case it's useful for the helper script or documentation: GPU detection (Windows): Install PyTorch per architecture (Windows): Architecture GPU series Command text onnxruntime should not be pinned ≥ 1.23 for ROCm (EP dropped). Use unpinned. triton can be skipped on Windows — no ROCm wheels exist, OneTrainer handles it gracefully. Tested on Windows 11, RX 9060 XT (RDNA4/gfx1200), ROCm 7.13.0a20260318. Happy to help with the helper script or docs if needed. |
Summary
The current
requirements-rocm.txtspecifiestorch==2.9.1+rocm6.3which only has wheels formanylinux_2_28_x86_64(Linux). This makes installation completely impossible on Windows, regardless of the install method.This PR replaces the Linux-only wheels with AMD's TheRock nightly index, which is the only source of ROCm PyTorch wheels for Windows.
Problem
Changes
--extra-index-url https://download.pytorch.org/whl/rocm6.3+ pinned versions with--find-linkspointing to AMD's TheRock nightly S3 bucketonnxruntime==1.23.2with plainonnxruntime— the ROCm Execution Provider was removed in ORT 1.23 (ROCm 7.0 was the last supported version). See ORT ROCm EP docs--preflag to allow nightly/pre-release builds from TheRockTested on
7.13.0a20260318(TheRock nightly)uv) and standaloneTheRock nightly index URLs
https://therock-nightly-python.s3.us-east-2.amazonaws.com/gfx103X-all/index.htmlhttps://therock-nightly-python.s3.us-east-2.amazonaws.com/gfx110X-all/index.htmlhttps://therock-nightly-python.s3.us-east-2.amazonaws.com/gfx120X-all/index.htmlNotes
--extra-index-url https://download.pytorch.org/whl/rocm6.3approach still works. A future improvement could auto-detect the OS and use the appropriate index.tritonis also missing on Windows (no ROCm Windows wheels exist for it) — OneTrainer already handles this gracefully withcontinueing without triton.