Open
Conversation
ordinalM
commented
Oct 30, 2019
- onConfigLoaded() wasn't using the right parameter to check config, so updated the variable name
- there was an issue with the filename when caching the index page - if simply "/" has been used the $url parameter was empty, resulting in a dot file that was hidden and hard to clear. In the case of an empty $url I amended the cache filename to be "index".
…url param to onRequestUrl() to "index" to avoid generating hidden dot file in cache
|
So apparently this was never merged. I'm not hopeful though, and I might create my own fork, although a few already exist: https://github.com/Nepose/pico_cache/network/members I do hope to incorporate all the good stuff from the other forks, esp. incl. GET requests in the cached pages (e.g. separately cached pages for /index?page=2 and /index?page=3 etc.), and lastly tackle the PicoCMS wiki to replace this apparently abandoned project? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.