Refine bot proactive reload criteria#1768
Open
sunzenshen wants to merge 3 commits intoNeotokyoRebuild:masterfrom
Open
Refine bot proactive reload criteria#1768sunzenshen wants to merge 3 commits intoNeotokyoRebuild:masterfrom
sunzenshen wants to merge 3 commits intoNeotokyoRebuild:masterfrom
Conversation
Contributor
|
Ran into this assert where the weapon the penetration of which was being tested was a smoke grenade. Not sure how to replicate and so test if its present on master too. 
|
sunzenshen
force-pushed
the
bot-reload-from-cover
branch
from
99fa667 to
0822264
Compare
sunzenshen
commented
Mar 3, 2026
| // Only bother with fire penetration in short distance | ||
| auto *neoWeapon = static_cast<CNEOBaseCombatWeapon *>(GetActiveWeapon()); | ||
| if (!neoWeapon) | ||
| if (!neoWeapon || !(neoWeapon->GetNeoWepBits() & NEO_WEP_FIREARM)) |
Contributor
Author
There was a problem hiding this comment.
Let's see if the attached stack trace scenario happens again after checking the NEO_WEP_FIREARM bit. This should filter out the smoke grenade case mentioned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tactical Monitor runs on a single thread, so bots can be in extended tactical situations that last longer than their ammo capacity. This PR adds more proactive reload checkpoints, while adding more criteria checks for when to reload.
Toolchain