Compact crosshair serialization + refactor#1766
Open
nullsystem wants to merge 1 commit intoNeotokyoRebuild:masterfrom
Open
Compact crosshair serialization + refactor#1766nullsystem wants to merge 1 commit intoNeotokyoRebuild:masterfrom
nullsystem wants to merge 1 commit intoNeotokyoRebuild:masterfrom
Conversation
nullsystem
force-pushed
the
GH-1765_CompactSerial
branch
from
628009b to
e4fcfb3
Compare
Instead of looping over or one sprintf, serialization done through function that steps each segment and serial + de-serial done in a unified function so if-statements and variable positions shouldn't differ too easily when editing. No longer explicitly check for segment lengths as it should just instead no-ops. Replaced hard- coded default string with function that sets the default values instead. * fixes NeotokyoRebuild#1765
nullsystem
force-pushed
the
GH-1765_CompactSerial
branch
from
e4fcfb3 to
fd9bd4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of looping over or one sprintf, serialization done through function that steps each segment and serial + de-serial done in a unified function so if-statements and variable positions shouldn't differ too easily when editing. No longer explicitly check for segment lengths as it should just instead no-ops. Replaced hard- coded default string with function that sets the default values instead.
Toolchain
Linked Issues