Skip to content

Updates packages#177

Open
elliotBraem wants to merge 3 commits intoNearSocial:devfrom
elliotBraem:update-packages
Open

Updates packages#177
elliotBraem wants to merge 3 commits intoNearSocial:devfrom
elliotBraem:update-packages

Conversation

@elliotBraem
Copy link
Copy Markdown
Contributor

@elliotBraem elliotBraem commented Feb 14, 2024

Needed to update packages and add polyfills to resolves build issues when creating this monorepo.

This is the working version, I tried a linked version with NearSocial/viewer and near-everything/viewer and had no problems either.

  • ethers stays at 5.7.2
  • upgrades github workflow build-check node version to 18

Comment thread webpack.config.js
Comment on lines +64 to +65
util: require.resolve("util"),
punycode: require.resolve("punycode"),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Comment thread package.json
"deep-equal": "^2.2.3",
"dompurify": "^3.0.8",
"elliptic": "^6.5.4",
"encoding": "^0.1.13",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's new, why?

Comment thread package.json
"react-infinite-scroller": "^1.2.6",
"react-markdown": "^7.1.0",
"react-singleton-hook": "^3.1.1",
"react-markdown": "^9.0.1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to verify this version doesn't expose something that can be used for XSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants