v2-refactor#700
Closed
gwleuverink wants to merge 13 commits into
Closed
Conversation
it used to live inside `Electron`.
Contributor
Author
|
I discussed this with @SRWieZ. We concluded that it is better to put everything under the Desktop namespace. I updated the PR to use this structure: The old Electron package now lives in The Builder related traits I mentioned moved to the |
Contributor
Author
|
This PR moved to NativePHP/desktop#1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves all of the code that does not directly involve Electron from the
Electronto theSupportnamespace.Native\Support\Bundlerclass.native:installscript topost-update-cmdautomatically.There is room for improvement, but incrementally I think this is a good first step.
Appreciate any thoughts on this!