Skip to content

Account for gearbox ratio in windio conversion#498

Open
dzalkind wants to merge 4 commits intoNatLabRockies:developfrom
dzalkind:windio_gearbox
Open

Account for gearbox ratio in windio conversion#498
dzalkind wants to merge 4 commits intoNatLabRockies:developfrom
dzalkind:windio_gearbox

Conversation

@dzalkind
Copy link
Copy Markdown
Collaborator

@dzalkind dzalkind commented Apr 9, 2026

Description and Purpose

Fix an issue where there was a discrepancy between windio control inputs (rotor-based) and rosco inputs (generator-based).

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

TODO Items General:

  • Add example/test for new feature
  • Update registry
  • Run testing

TODO Items API Change:

  • Update docs with API change
  • Run update_rosco_discons.py in Test_Cases/
  • Update DISCON schema

Github issues addressed, if one exists

Examples/Testing, if applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dzalkind