hpxml heat pump performance data#143
Closed
kendallbaertlein wants to merge 46 commits intoNatLabRockies:mainfrom
Closed
hpxml heat pump performance data#143kendallbaertlein wants to merge 46 commits intoNatLabRockies:mainfrom
kendallbaertlein wants to merge 46 commits intoNatLabRockies:mainfrom
Conversation
Note:; this covers the ENERGY STAR and HIgh efficiency cold climate heat pump upgrades from ResStock 2024. For details, see: https://resstock.nrel.gov/datasets https://www.nrel.gov/docs/fy24osti/89600.pdf Addresses NatLabRockies#128 - [x] Reference the issue your PR is fixing - [x] Assign at least 1 reviewer for your PR - [x] Test with run_dwelling.py or other script - [x] Update documentation as appropriate - [x] Update changelog as appropriate
Various updates to accept HPXML files from OS-HPXML v1.7 (and therefore ResStock 3.2). Major changes and fixes: - Revised/renamed spa equipment - Fixed garage interior ceiling connections - Fixed issue with adjacent doors (e.g., for multi-family units, hallways) - PV model takes roof azimuth and tilt if not provided - Updated documentation A few things we haven't addressed yet (and probably won't until accepting OS-HPXML v1.8) - Cathedral ceilings - [x] Reference the issue your PR is fixing - [x] Assign at least 1 reviewer for your PR - [x] Test with run_dwelling.py or other script - [x] Update documentation as appropriate - [x] Update changelog as appropriate
DSE is set to 1 for Room AC Fixes NatLabRockies#99 - [x] Reference the issue your PR is fixing - [x] Assign at least 1 reviewer for your PR - [x] Test with run_dwelling.py or other script - [ ] Update documentation as appropriate - [ ] Update changelog as appropriate
…is expecting files generated by ResStock or BEopt, and there were some issues with HPXML files not worth the time to resolve.
…. Thanks Kendall!
…tion etc. of detailed performance data
mnblonsky
changed the title
Collaborator
|
I think we'll need to open a new branch/PR to add HP performance curves. There's some good code in |
Collaborator
|
Closing, all useful code is in #142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.