[tests/e2e] reduce requirements to run 'test-preinstalled' make target#1799
Open
cdesiniotis wants to merge 1 commit intoNVIDIA:mainfrom
Open
[tests/e2e] reduce requirements to run 'test-preinstalled' make target#1799cdesiniotis wants to merge 1 commit intoNVIDIA:mainfrom
cdesiniotis wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Prior to this commit, it was required to define the E2E_IMAGE_NAME and E2E_IMAGE_TAG variables when invoking the 'test-preinstalled' make target even though they are never used. This commit removes this requirement to reduce friction when running e2e tests locally. Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
Coverage Report for CI Build 25407821807Coverage remained the same at 43.32%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
tariq1890
approved these changes
May 6, 2026
elezar
approved these changes
May 6, 2026
Contributor
Author
|
/cherry-pick release-1.19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, it was required to define the E2E_IMAGE_NAME and E2E_IMAGE_TAG variables when invoking the 'test-preinstalled' make target even though they are never used. This commit removes this requirement to reduce friction when running e2e tests locally.